This repository was archived by the owner on Jun 28, 2024. It is now read-only.
Merged
Conversation
added 2 commits
June 20, 2019 14:44
Move the URL checking logic into a new function to make the behaviour clearer. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add helpful error messages to show the user why the URL check failed. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Contributor
|
Maybe I'm missing something, but I don't see the 'retry 3 times' code? Is it subtle? |
If a URL check fails, retry 3 times (by default) in case of transitory network errors. Fixes: kata-containers#1734. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Author
|
Last commit? However, I've now made it clearer by using |
3943d78 to
f1920e7
Compare
grahamwhaley
approved these changes
Jun 20, 2019
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
Ta. I think I just missed seeing that commit completely before.
lgtm
GabyCT
approved these changes
Jun 20, 2019
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a URL check fails, retry 3 times (by default) in case of transitory network errors.
Fixes: #1734.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com