This repository was archived by the owner on Jun 28, 2024. It is now read-only.
ci: lib.sh: set PATH for sudo even in no-go case#1498
Merged
GabyCT merged 1 commit intokata-containers:masterfrom Apr 24, 2019
Merged
ci: lib.sh: set PATH for sudo even in no-go case#1498GabyCT merged 1 commit intokata-containers:masterfrom
GabyCT merged 1 commit intokata-containers:masterfrom
Conversation
If the scripts failed to find go or a GOPATH they would follow a different path and invoke `sudo -E`, but not with the PATH=$PATH argument. This normally works on oru CIs, but on Zuul, where the old distro go version will be in the sudo path first, it fails with a 'go too old' error. Pass the CI env/user PATH into the `sudo` to ensure we pick up the correct golang. Fixes: kata-containers#1479 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
Contributor
Author
|
/test |
GabyCT
approved these changes
Apr 24, 2019
chavafg
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the scripts failed to find go or a GOPATH they would follow a different
path and invoke
sudo -E, but not with the PATH=$PATH argument. Thisnormally works on oru CIs, but on Zuul, where the old distro go version
will be in the sudo path first, it fails with a 'go too old' error.
Pass the CI env/user PATH into the
sudoto ensure we pick upthe correct golang.
Fixes: #1479
Signed-off-by: Graham Whaley graham.whaley@intel.com