Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

k8s: disable host cache empty dir test#1433

Merged
chavafg merged 1 commit intokata-containers:masterfrom
awprice:update-k8s-empty-dir-tests
Apr 12, 2019
Merged

k8s: disable host cache empty dir test#1433
chavafg merged 1 commit intokata-containers:masterfrom
awprice:update-k8s-empty-dir-tests

Conversation

@awprice
Copy link
Copy Markdown
Contributor

@awprice awprice commented Apr 9, 2019

Depends-on: github.com/kata-containers/runtime#1485

Fixes #1432

Signed-off-by: Alex Price aprice@atlassian.com

@awprice
k8s: disable host cache empty dir test
30a2c70 
Depends-on: github.com/kata-containers/runtime#1485

Fixes kata-containers#1432

Signed-off-by: Alex Price <aprice@atlassian.com>
@amshinde
Copy link
Copy Markdown
Member

amshinde commented Apr 9, 2019

/test

@amshinde
Copy link
Copy Markdown
Member

amshinde commented Apr 9, 2019

@egernst @chavafg ptal

@awprice awprice mentioned this pull request Apr 9, 2019
Merged
egernst
egernst approved these changes Apr 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@egernst egernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will we be adding a new test soon it’s place?

@awprice
Copy link
Copy Markdown
Contributor Author

awprice commented Apr 9, 2019

Looks good. Will we be adding a new test soon it’s place?

Yep, I'd be happy to add a new test.

@chavafg chavafg mentioned this pull request Apr 9, 2019
Merged
@GabyCT
Copy link
Copy Markdown
Contributor

GabyCT commented Apr 11, 2019

/test

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Apr 12, 2019

/retest

@chavafg chavafg merged commit 372e12f into kata-containers:master Apr 12, 2019
@awprice awprice deleted the update-k8s-empty-dir-tests branch April 16, 2019 23:46
@awprice
Copy link
Copy Markdown
Contributor Author

awprice commented Apr 16, 2019

@egernst / @chavafg / @amshinde Apologies for commenting on a closed PR, but correct me if I'm wrong, but I don't think removing the test in this PR was needed in the end, as kata-containers/runtime#1485 was passing without this PR being merged.

Is it possible to revert/add this test back in?

@amshinde
Copy link
Copy Markdown
Member

amshinde commented Apr 17, 2019

@awprice This test was checking if the empty-dir was mounted as 9p with grep "/host/cache type 9p" and hence was required to be removed as with the runtime PR, this is no longer the case.
The test needs to be modified to check for the correct mount type now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@amshinde amshinde amshinde approved these changes

@egernst egernst egernst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Kubernetes emptyDir tests

5 participants

@awprice @amshinde @GabyCT @chavafg @egernst