Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

CI: codecov/patch check issue #508

@bergwolf

Description

@bergwolf

Not sure if this is the right place to raise this but I want to raise an issue w.r.t. codecov/patch check in out PR CI check list, after digging through a failure in kata-containers/runtime/pull/458.

The codecov failure on that PR (codecov/patch — 39.13% of diff hit (target 64.16%)) looks bogus since clearly the patch is already properly tested with UT.

Looking at https://codecov.io/gh/kata-containers/runtime/commit/b821a5df4c1adb154613b80f981ba16684ed8b80, the change in kata_agent.go is clearly covered by UT in kata_agent_test.go but the patch diff coverage for kata_agent.so is reported as 0%.

This looks to be an issue on codecov.io side. I would suggest we either remove codecov/patch, or always ignore it during reviewing.

@egernst @sboeuf @jodh-intel @grahamwhaley @WeiZhang555 @gnawux WDYT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions