Conversation
|
PSS Measurement: Memory inside container: |
|
Build failed (third-party-check pipeline) integration testing with
|
Sadly CI failed to catch the broken line due to the fact that it is introduced by a different PR that passed w/o the naming PR. ./config.go:604:27: config.DefaultMemSz undefined (type virtcontainers.HypervisorConfig has no field or method DefaultMemSz) Makefile:331: recipe for target '/golang/src/github.com/kata-containers/runtime/kata-runtime' failed make: *** [/golang/src/github.com/kata-containers/runtime/kata-runtime] Error 2 Fixes: kata-containers#709 Signed-off-by: Peng Tao <bergwolf@gmail.com>
|
PSS Measurement: Memory inside container: |
|
LGTM Why CI didn't catch the broken line? Weird |
|
@WeiZhang555 It was merged in as a different PR which passed itself w/o the hypervisor config field rename. CI validation only merges the current PR to master. So even if two PRs both pass independently but when they are both merged to master, build may still break. |
|
Build failed (third-party-check pipeline) integration testing with
|
|
I see. This is hard to resolve, unless we force each PR to rebase and run another round of CI test before merging, even so there's still potential break possibility. |
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=========================================
Coverage ? 65.32%
=========================================
Files ? 85
Lines ? 9945
Branches ? 0
=========================================
Hits ? 6497
Misses ? 2796
Partials ? 652 |
jodh-intel
left a comment
There was a problem hiding this comment.
Good catch and ... ouch! 😭
/cc @chavafg.
|
Merging as we kinda need a buildable source tree... ;) |
|
@sboeuf Yes, you are right. |
|
Thanks for confirmation. |
Sadly CI failed to catch the broken line due to the fact that it is introduced by a different
PR that passed w/o the naming PR.
Fixes: #709