This repository was archived by the owner on May 12, 2021. It is now read-only.
Hypervisor: UUID fix for acrn hypevisor#2075
Merged
jcvenegas merged 1 commit intokata-containers:masterfrom Oct 4, 2019
Merged
Hypervisor: UUID fix for acrn hypevisor#2075jcvenegas merged 1 commit intokata-containers:masterfrom
jcvenegas merged 1 commit intokata-containers:masterfrom
Conversation
devimc
reviewed
Sep 19, 2019
| // AcrnInfo keeps PID of the hypervisor | ||
| // acrnUUIDsToIdx lists Idx corresponding to the UUID | ||
| var acrnUUIDsToIdx = map[string]uint8{ | ||
| "a7ada506-1ab0-4b6b-a0da-e513ca9b8c2f": 0, |
There was a problem hiding this comment.
woow, this looks like black magic 😄 , could you please include a comment explaining what mean or from where did you get these IDs ?
Contributor
Author
There was a problem hiding this comment.
Added comments.
virtcontainers/store/vc.go
Outdated
|
|
||
| // VCStoreUUIDPath returns a virtcontainers runtime uuid URL. | ||
| func VCStoreUUIDPath() string { | ||
| return filesystemScheme + "://" + filepath.Join(VMUUIDStoragePath) |
There was a problem hiding this comment.
filepath.Join with only one argument? this looks odd 🤔
Contributor
Author
There was a problem hiding this comment.
Just used string concatenation "+" instead of join.
Contributor
Author
|
Thanks @devimc . Any other feedback on the patch? |
This patch adds support for getting the kata UUID from acrn hypervisor and using these UUID to create a VM. Fixes: kata-containers#1785 Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
c70926b to
aa6a16c
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
=========================================
Coverage ? 53.21%
=========================================
Files ? 109
Lines ? 16259
Branches ? 0
=========================================
Hits ? 8653
Misses ? 6560
Partials ? 1046 |
devimc
approved these changes
Sep 25, 2019
jcvenegas
approved these changes
Oct 2, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for getting the kata UUID from
acrn hypervisor and using these UUID to create a VM.
Fixes: #1785
Signed-off-by: Vijay Dhanraj vijay.dhanraj@intel.com