This repository was archived by the owner on May 12, 2021. It is now read-only.
add watchconsole for no_proxy type#1933
Merged
bergwolf merged 1 commit intokata-containers:masterfrom Aug 16, 2019
Merged
Conversation
726a1fd to
933053e
Compare
Member
Author
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1933 +/- ##
==========================================
- Coverage 52.16% 51.78% -0.39%
==========================================
Files 108 107 -1
Lines 14227 14535 +308
==========================================
+ Hits 7422 7527 +105
- Misses 5923 6124 +201
- Partials 882 884 +2 |
devimc
reviewed
Aug 6, 2019
virtcontainers/proxy.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| // TODO: add pty console support for kvmtools |
There was a problem hiding this comment.
could you please file an issue and mention it here?
933053e to
e9beb5e
Compare
|
/test |
devimc
approved these changes
Aug 7, 2019
amshinde
reviewed
Aug 12, 2019
virtcontainers/proxy.go
Outdated
| return -1, "", fmt.Errorf("kata proxy running for sandbox %s", params.id) | ||
| } | ||
|
|
||
| params.logger.Debug("Starting kata proxy") |
Member
There was a problem hiding this comment.
@lifupan This will be logged for the the noProxy.start() as well which is not desired.
Similarly I would suggest changing the above Error message as well to something like "Error setting up console" for the noProxy case, else the user may think that an actual proxy is running looking at the logs/errors.
For no proxy type, we also need the feature of watch hypervisor's console to help debug. Fixes:kata-containers#1932 Signed-off-by: lifupan <lifupan@gmail.com>
e9beb5e to
31ddb4d
Compare
Member
Author
|
/test |
|
restarting ubuntu and firecracker CI |
jodh-intel
approved these changes
Aug 15, 2019
amshinde
approved these changes
Aug 15, 2019
bergwolf
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For no proxy type, we also need the feature
of watch hypervisor's console to help debug.
Fixes:#1932
Signed-off-by: lifupan lifupan@gmail.com