This repository was archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: support SMP die#1914
Merged
devimc merged 2 commits intokata-containers:masterfrom Jul 26, 2019
Merged
Conversation
Author
|
/test |
jodh-intel
approved these changes
Jul 26, 2019
| if machine.Type == "pseries" || machine.Type == "s390-ccw-virtio" { | ||
| socketID = "" | ||
| threadID = "" | ||
| dieID = "" |
There was a problem hiding this comment.
Nit: the comment needs updating for dieID :) I'd be tempted to change it to:
// If CPU type is IBM pSeries or Z, we do not set the following./cc @alicefr since this affects s390x.
Author
There was a problem hiding this comment.
I think she agrees with this change kata-containers/govmm#103 (comment)
0d0057a to
777e151
Compare
Author
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
=======================================
Coverage 52.19% 52.19%
=======================================
Files 108 108
Lines 14196 14196
=======================================
Hits 7410 7410
Misses 5907 5907
Partials 879 879 |
jcvenegas
approved these changes
Jul 26, 2019
Shortlog: 68cdf64 test: add cpu topology tests e0cf9d5 qmp: add checks for the CPU toplogy a5c1190 qemu: support x86 SMP die Signed-off-by: Julio Montes <julio.montes@intel.com>
777e151 to
3a446ce
Compare
Author
|
/test |
3a446ce to
65df6d7
Compare
Author
|
/test |
65df6d7 to
7ac8e79
Compare
Author
|
/test |
7ac8e79 to
091a28b
Compare
Author
|
/test |
CPU topology has changed in QEMU 4.1: socket > die > core > thread. die option must be specified in order to hotplug CPUs on x86_64 Depends-on: github.com/kata-containers/packaging#657 fixes kata-containers#1913 Signed-off-by: Julio Montes <julio.montes@intel.com>
091a28b to
7668aeb
Compare
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU topology has changed in QEMU 4.1: socket > die > core > thread.
die option must be specified in order to hotplug CPUs on x86_64
Depends-on: github.com/kata-containers/packaging#657
fixes #1913
Signed-off-by: Julio Montes julio.montes@intel.com