This repository was archived by the owner on May 12, 2021. It is now read-only.
shimv2: Add missing page size to Hugetlb Stat#1857
Merged
lifupan merged 1 commit intokata-containers:masterfrom Jul 4, 2019
Merged
shimv2: Add missing page size to Hugetlb Stat#1857lifupan merged 1 commit intokata-containers:masterfrom
lifupan merged 1 commit intokata-containers:masterfrom
Conversation
amshinde
approved these changes
Jul 3, 2019
egernst
reviewed
Jul 3, 2019
Member
egernst
left a comment
There was a problem hiding this comment.
Thanks for the commit Odin - lgtm, though you'll need to amend the commit header itself to appease formatting expectations.
Header should be: shimv2: Add missing page size to Hugetlb Stat
And, I'm guessing you'll see a complaint re: reference to the issue it is resolving. It should be:
Fixes: #1856
Fixes: kata-containers#1856 Signed-off-by: Odin Ugedal <odin@ugedal.com>
7a312e1 to
da7f5f3
Compare
Contributor
Author
|
Hi @egernst ! Sorry, totally forgot that 🙃 You do indeed have awesome contribution docs, way better than most open source projects! I really like having proper consistency in stuff like this, so keep up the good work. Should be good to go now. |
Member
|
/test |
lifupan
approved these changes
Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=========================================
- Coverage 54.01% 54% -0.01%
=========================================
Files 106 106
Lines 13167 13168 +1
=========================================
Hits 7112 7112
- Misses 5208 5209 +1
Partials 847 847 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=========================================
- Coverage 54.01% 54% -0.01%
=========================================
Files 106 106
Lines 13167 13168 +1
=========================================
Hits 7112 7112
- Misses 5208 5209 +1
Partials 847 847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1856
Signed-off-by: Odin Ugedal odin@ugedal.com