This repository was archived by the owner on May 12, 2021. It is now read-only.
empty-dir: Fix bug in the way empty-dirs are handled for overlay#1826
Merged
egernst merged 1 commit intokata-containers:masterfrom Jul 1, 2019
Merged
empty-dir: Fix bug in the way empty-dirs are handled for overlay#1826egernst merged 1 commit intokata-containers:masterfrom
egernst merged 1 commit intokata-containers:masterfrom
Conversation
Member
Author
|
cc @awprice |
jodh-intel
reviewed
Jun 25, 2019
| // handleLocalStorage handles local storage within the VM | ||
| // by creating a directory in the VM from the source of the mount point. | ||
| func (k *kataAgent) handleLocalStorage(mounts []specs.Mount, sandboxID string) []*grpc.Storage { | ||
| func (k *kataAgent) handleLocalStorage(mounts []specs.Mount, sandboxID string, rootfsSuffix string) []*grpc.Storage { |
There was a problem hiding this comment.
This function doesn't have any unit tests so I think, given the subtle nature of this bug, we need one.
egernst
reviewed
Jun 26, 2019
Member
egernst
left a comment
There was a problem hiding this comment.
LGTM, though agree wrt unit test.
With kata-containers#1485, we moved the default medium empty-dir creation to the sandbox rootfs. This worked for devicemapper, but in case of overlay the "local" directory was being created outside the sandbox rootfs. As a result we were seeing the behaviour seen in kata-containers#1818. Fixes kata-containers#1818 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
15ce800 to
57136fa
Compare
Member
Author
|
@jodh-intel @egernst Test added! |
Member
Author
|
/test |
|
Ping @kata-containers/runtime ! |
Member
|
Looks this PR make the behavior of overlay identical to DeviceMapper, which is good to me. While having chatted with @bergwolf, he has some other suggestions. |
bergwolf
reviewed
Jun 28, 2019
egernst
approved these changes
Jul 1, 2019
Member
|
@bergwolf let's pull in further changes in new PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #1485, we moved the default medium empty-dir creation to the
sandbox rootfs. This worked for devicemapper, but in case of overlay
the "local" directory was being created outside the sandbox rootfs.
As a result we were seeing the behaviour seen in #1818.
Fixes #1818
Signed-off-by: Archana Shinde archana.m.shinde@intel.com