This repository was archived by the owner on May 12, 2021. It is now read-only.
trace: Add missing log message#1815
Merged
jcvenegas merged 1 commit intokata-containers:masterfrom Jun 20, 2019
Merged
Conversation
Add a log message for every trace span created, required by the tracing tests to validate tracing is working. Fixes: kata-containers#1814. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Author
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
=======================================
Coverage 54.59% 54.59%
=======================================
Files 106 106
Lines 13035 13035
=======================================
Hits 7117 7117
Misses 5071 5071
Partials 847 847 |
Member
|
opened issue to track the CI failures: kata-containers/tests#1745 |
amshinde
approved these changes
Jun 19, 2019
jcvenegas
approved these changes
Jun 20, 2019
Member
restarting cri-o job not related with this PR the error centos failed due to timeout, @jodh-intel is this something you consider should be a fix for stable branches ? I dont think this is critical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a log message for every trace span created, required by the tracing tests to validate tracing is working.
Fixes: #1814.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com