This repository was archived by the owner on May 12, 2021. It is now read-only.
runtime : delete redundant code in CreateContainer#1741
Merged
caoruidong merged 1 commit intokata-containers:masterfrom May 27, 2019
Merged
runtime : delete redundant code in CreateContainer#1741caoruidong merged 1 commit intokata-containers:masterfrom
caoruidong merged 1 commit intokata-containers:masterfrom
Conversation
Here we have done with logger and container ID map Just delete these code. fixes kata-containers#1740 Signed-off-by: Haomin Tsai <caihaomin@huawei.com>
Member
Author
|
/test |
Member
Author
|
ping @lifupan @jodh-intel |
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
- Coverage 56.09% 54.57% -1.52%
==========================================
Files 43 106 +63
Lines 4200 12767 +8567
==========================================
+ Hits 2356 6968 +4612
- Misses 1661 4967 +3306
- Partials 183 832 +649 |
bergwolf
approved these changes
May 27, 2019
Member
bergwolf
left a comment
There was a problem hiding this comment.
Looks like some merge fuzz when applying patches by hand. Nice catch!
lifupan
approved these changes
May 27, 2019
caoruidong
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we have done with logger and container ID map
Just delete these code.
fixes #1740
Signed-off-by: Haomin Tsai caihaomin@huawei.com