Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

data: Revert pull request #1405#1724

Merged
GabyCT merged 1 commit intokata-containers:masterfrom
devimc:topic/data/revert1405
May 23, 2019
Merged

data: Revert pull request #1405#1724
GabyCT merged 1 commit intokata-containers:masterfrom
devimc:topic/data/revert1405

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented May 22, 2019

The rootfs image was fixed, now the DAX metadata and 2 MBRs headers are part
of the same image. Mounting the rootfs partiton with an offset of 2M is no
more needed, since the first MBR is read by partx or losetup by default.

fixes #1443

cc @jodh-intel

Signed-off-by: Julio Montes julio.montes@intel.com

The rootfs image was fixed, now the DAX metadata and 2 MBRs headers are part
of the same image. Mounting the rootfs partiton with an offset of 2M is no
more needed, since the first MBR is read by partx or losetup by default.

fixes kata-containers#1443

Signed-off-by: Julio Montes julio.montes@intel.com
@devimc
Copy link
Copy Markdown
Author

devimc commented May 22, 2019

/test

Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

#!/bin/bash
#
# Copyright (c) 2017-2019 Intel Corporation
# Copyright (c) 2017-2018 Intel Corporation
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been playing with that time machine again @devimc? :) This is strictly correct (it's a revert), but does look at bit confusing ;)

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GabyCT GabyCT merged commit 9a65c18 into kata-containers:master May 23, 2019
This was referenced Jun 3, 2019
@devimc devimc deleted the topic/data/revert1405 branch October 9, 2019 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert #1405

5 participants