This repository was archived by the owner on May 12, 2021. It is now read-only.
shimv2: remove use containerd ns as netns#1722
Merged
devimc merged 1 commit intokata-containers:masterfrom May 22, 2019
Ace-Tang:rm-ns
Merged
shimv2: remove use containerd ns as netns#1722devimc merged 1 commit intokata-containers:masterfrom Ace-Tang:rm-ns
devimc merged 1 commit intokata-containers:masterfrom
Ace-Tang:rm-ns
Conversation
Ace-Tang
commented
May 22, 2019
| } | ||
|
|
||
| if n.Path == "" { | ||
| n.Path = netns |
Contributor
Author
There was a problem hiding this comment.
Just say，this code is wrong, n is a temporary value， so n.Path is not changed
Member
|
@Ace-Tang Thanks for the fix, I'm fine with this change once you fixed the travis failure. |
```
//the network namespace created by cni plugin
netns, err = namespaces.NamespaceRequired(ctx)
if err != nil {
return nil, errors.Wrap(err, "create namespace")
}
```
the netns is a containerd namespace concept, it not netns, event a cni
set netns for this, this is a tricky way, so remove the logic.
Fixes: #1692
Signed-off-by: Ace-Tang <aceapril@126.com>
Contributor
Author
|
Updated, |
Member
|
/test |
jodh-intel
approved these changes
May 22, 2019
| } | ||
|
|
||
| if n.Path == "" { | ||
| n.Path = netns |
lifupan
approved these changes
May 22, 2019
devimc
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the netns is a containerd namespace concept, it not netns, event a cni
set netns for this, this is a tricky way, so remove the logic.
Fixes: #1692
Signed-off-by: Ace-Tang aceapril@126.com