Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

nemu: update nemu version#1710

Merged
chavafg merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:nemu-ci
May 23, 2019
Merged

nemu: update nemu version#1710
chavafg merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:nemu-ci

Conversation

@ganeshmaharaj
Copy link
Copy Markdown
Contributor

@ganeshmaharaj ganeshmaharaj commented May 18, 2019

virtio-fs is now available in 1.7 release and needs hugepages enabled.
NEMU's machine_type virt has issues getting network access when
hugepages is enabled. Temporarily changing type to pc to fix this
issue. Accompanying changes to runtime and tests are underway.

Fixes: #1709
Signed-off-by: Ganesh Maharaj Mahalingam ganesh.mahalingam@intel.com

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 18, 2019

/test-nemu

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 18, 2019

/test-nemu

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 18, 2019 •
edited
Loading 

16:48:52 [3] • Failure [11.556 seconds]
16:48:52 [3] Hotplug memory when create containers
16:48:52 [3] /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-nemu/go/src/github.com/kata-containers/tests/integration/docker/mem_test.go:47
16:48:52 [3]   Hotplug memory when create containers
16:48:52 [3]   /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-nemu/go/src/github.com/kata-containers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table.go:92
16:48:52 [3]     hotplug memory when create containers should not fail [It]
16:48:52 [3]     /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-nemu/go/src/github.com/kata-containers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:46
16:48:52 [3] 
16:48:52 [3]     Expected
16:48:52 [3]         <int>: 125
16:48:52 [3]     to be zero-valued
16:48:52 [3] 
16:48:52 [3]     /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-nemu/go/src/github.com/kata-containers/tests/integration/docker/mem_test.go:74
16:48:52 [3] ------------------------------
16:48:52 [3] 
16:48:52 [3] 
16:48:52 [3] Summarizing 1 Failure:
16:48:52 [3] 
16:48:52 [3] [Fail] Hotplug memory when create containers Hotplug memory when create containers [It] hotplug memory when create containers should not fail 
16:48:52 [3] /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-nemu/go/src/github.com/kata-containers/tests/integration/docker/mem_test.go:74
16:48:52 [3] 
16:48:52 [3] Ran 18 of 20 Specs in 363.967 seconds
16:48:52 [3] FAIL! -- 17 Passed | 1 Failed | 0 Pending | 2 Skipped --- FAIL: TestIntegration (363.97s)

Should memory hotplug fail with NEMU @jcvenegas @egernst ?

Update:
Kindly ignore this comment. I had pulled in the virtio_fs changes which we know fails today with memory hotplug. Had to remove that from tests and now nemu builds pass.

jodh-intel
jodh-intel reviewed May 20, 2019
View reviewed changes
@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 20, 2019

/test-nemu

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 21, 2019

/test

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 22, 2019

The latest release of NEMU works fine with hugepages and this change is no longer needed. Will fix the other patches to make use of the new release.

@ganeshmaharaj ganeshmaharaj reopened this May 22, 2019
@devimc
Copy link
Copy Markdown

devimc commented May 22, 2019

/test

@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 22, 2019

@chavafg the fedora build is failing with

INFO: ensuring docker is running
panic: ERROR: docker daemon is not installed, not running, or not accessible to current user: Client:
 Version:           18.06.3-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        d7080c1
 Built:             Wed Feb 20 02:27:18 2019
 OS/Arch:           linux/amd64
 Experimental:      false
Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.38/version: dial unix /var/run/docker.sock: connect: permission denied (error exit status 1)

Am i missing something in my change?

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented May 22, 2019

weird failure, hadn't seen it before, sent rebuild

@chavafg chavafg changed the title nemu-config: fix nemu for ci nemu: update nemu version May 22, 2019
@ganeshmaharaj
Copy link
Copy Markdown
Contributor Author

ganeshmaharaj commented May 23, 2019

fedora build is failing with

Running command '/usr/local/bin/kata-runtime [kata-runtime --log=/tmp/bundle260202801/log run --bundle=/tmp/bundle260202801 --console= --pid-file=/tmp/bundle260202801/pid --detach GmbX6ldzoHqB71yVBlmJ]'
command failed error 'exit status 1'
[kata-runtime --log=/tmp/bundle260202801/log run --bundle=/tmp/bundle260202801 --console= --pid-file=/tmp/bundle260202801/pid --detach GmbX6ldzoHqB71yVBlmJ]
Timeout: 120 seconds
Exit Code: 1
Stdout: 
Stderr: Failed to check if grpc server is working: rpc error: code = Unavailable desc = transport is closing

Ubuntu arm build is failing with issues on chrony.

13:00:05 • Failure [6.833 seconds]
13:00:05 check dmesg logs errors
13:00:05 /home/jenkins/workspace/kata-containers-runtime-ARM-18.04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:277
13:00:05   Run to check dmesg log errors
13:00:05   /home/jenkins/workspace/kata-containers-runtime-ARM-18.04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:294
13:00:05     should be empty [It]
13:00:05     /home/jenkins/workspace/kata-containers-runtime-ARM-18.04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:295
13:00:05 
13:00:05     Expected
13:00:05         <string>: [    0.000000] systemd[59]: chronyd.service: Failed to set up mount namespacing: No such file or directory
13:00:05         [    0.000000] systemd[59]: chronyd.service: Failed at step NAMESPACE spawning /usr/sbin/chronyd: No such file or directory
13:00:05     to be empty
13:00:05 
13:00:05     /home/jenkins/workspace/kata-containers-runtime-ARM-18.04-PR/go/src/github.com/kata-containers/tests/integration/docker/run_test.go:305
13:00:05 ------------------------------
13:00:05 SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
13:00:05

I don't think the NEMU hypervisor is used in any other job other than nemu right @chavafg @jcvenegas ?

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented May 23, 2019

@ganeshmaharaj - ARM and fedora CI fails - will let for you to work out.

nemu-config: fix nemu for ci
722ac5a 
virtio-fs is now available in 1.7 release and needs hugepages enabled.
Updating version of NEMU that ships with kata by default which contains
the fixes for hugepages, machine_type=virt and network access.

Fixes: kata-containers#1709
Depends-on: github.com/kata-containers/tests#1595
Depends-on: github.com/kata-containers/packaging#522
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented May 23, 2019

/test
afaik, nemu is only tested on the nemu CI, yes.
That chrony fail might be related to a v.recent change /cc @devimc @chavafg
I see you pushed a change, so need to spin all the CIs again anyway...

@devimc
Copy link
Copy Markdown

devimc commented May 23, 2019

chronyd is failing because it's not installed in the rootfs image generated in ARM

cc @Pennyzct @jongwu

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented May 23, 2019

Fedora jobs are unstable right now and ARM machine is offline. This change does not affect any of those jobs, so I think we are fine merging this change.

@chavafg chavafg merged commit b22d0a7 into kata-containers:master May 23, 2019
@Pennyzct
Copy link
Copy Markdown
Contributor

Pennyzct commented May 23, 2019

Thanks for the notification.:) @devimc. We will try to re-build connection between master and ARM ci node, bring it online firstly, then we will follow up the chronyd issue :).

This was referenced Jun 3, 2019
Merged
Merged
@ganeshmaharaj ganeshmaharaj deleted the nemu-ci branch July 17, 2019 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@amshinde amshinde amshinde approved these changes

@chavafg chavafg chavafg approved these changes

@devimc devimc devimc approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

change nemu machine_type to pc to handle virtio-fs failures.

7 participants

@ganeshmaharaj @devimc @chavafg @grahamwhaley @Pennyzct @amshinde @jodh-intel