This repository was archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: agent: implement kata agent processListContainer#130
Merged
devimc merged 3 commits intokata-containers:masterfrom Apr 19, 2018
Merged
Conversation
Author
|
Depends-on: kata-containers/agent#194 |
sboeuf
approved these changes
Mar 28, 2018
sboeuf
left a comment
There was a problem hiding this comment.
This looks good to me (depending on the fact that we get the agent PR merged of course).
9432d90 to
99fbaaa
Compare
383a677 to
bebfd41
Compare
Author
|
rebased, @bergwolf @egernst @gnawux @laijs @mcastelino @sameo @tallclair @teawater @WeiZhang555 @liwei @jessfraz @kata-containers/runtime PTAL |
Member
|
@devimc CI is failing, can you fix that? |
|
lgtm |
bergwolf
approved these changes
Apr 18, 2018
a6f8a7e to
561da7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 65.26% 65.16% -0.11%
==========================================
Files 74 74
Lines 7730 7742 +12
==========================================
Hits 5045 5045
- Misses 2135 2147 +12
Partials 550 550
Continue to review full report at Codecov.
|
Author
|
@bergwolf done, thanks |
added 3 commits
April 18, 2018 10:40
processListContainer is called by the ps command implementation to list the processes running inside a containers, this patch implements this function in the kata agent fixes kata-containers#129 Signed-off-by: Julio Montes <julio.montes@intel.com>
This new version of kata agent contains changes to list the processes that are running inside the VM Shortlog: ff7eaa1 grpc: add unit test for ListProcesses c394b63 mockcontainer: implement mockContainer d208929 mockreaper: add unit tests 01bc953 grpc: implement ListProcesses Signed-off-by: Julio Montes <julio.montes@intel.com>
add ListProcesses to gRPCProxy to make it compatible with AgentServiceServer. Signed-off-by: Julio Montes <julio.montes@intel.com>
561da7c to
01f3f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processListContainer is called by the ps command implementation to
list the processes running inside a containers, this patch implements
this function in the kata agent
fixes #129
Signed-off-by: Julio Montes julio.montes@intel.com