Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

network: AddInterface only supports VirtualEndpoints #758

@sboeuf

Description

@sboeuf

If we look at the way AddInterface() has been implemented, it will always create a virtualEndpoint, no matter the type of device backing the interface that we're trying to add. Unfortunately, this means neither vhost-user nor vfio can be leveraged in this case.

This needs to be fixed either by adding a new field devType to the grpc.Interface structure passed as an argument of AddInterface(), or by adding a new argument devType directly to the function itself.

@bergwolf @caoruidong @WeiZhang555 @amshinde WDYT?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions