Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

tests: may be leaking tmpfiles when run #480

@grahamwhaley

Description

@grahamwhaley

Description of problem

I believe the make test tests might be leaking tmpfiles when they are run.
Normally we probably don't care, as the CI oneshot VMs the tests run in just get torn down and thrown away - but, as I'm trying to strong encourage and enable developers to run the tests locally before they land PRs, we should make this clean.

Expected result

Nothing left dangling on the machine you run the tests upon.

Actual result

I have a bunch of dirs in my /tmp that upon inspection have a bundle/config.json path/file in them.
I suspect these were coming from invocations of makeOCIBundle, but I can only find one instance that does not defer the rmall of the tmpdir:
https://github.com/kata-containers/runtime/blob/master/cli/run_test.go#L171

I strongly suspect we have other leaks as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions