You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 12, 2021. It is now read-only.
bash -x .ci/go-no-os-exit.sh
+ go_packages=.
++ go list -f '{{.Dir}}/*.go' .
can't load package: package github.com/kata-containers/runtime: no Go files in /home/gwhaley/gopath/src/github.com/kata-containers/runtime
+ candidates=
+ egrep -n '\<os\.Exit\>'
The problem being the go list finds no dirs to process, and then the egrep ends up looking at stdin, forever.
I have a feeling we don't see this in the CIs maybe as they don't have a tty associated with them, so maybe they silently fail.
Expected result
I expect it to run the check on all the .go files, or fail gracefully at least - both on the CI and if run by hand.
Action
Probably:
Add an echo so we know that test is being run
Add a check for 'no files to process', echo that status out, and fail gracefully
Decide/check that finding 'no go files' in the runtime is the right action - as it is quite possibly not - it should probably be checking all files in virtcontainers and the cli dirs.