Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

Firecracker toml result in failure to boot #1761

@egernst

Description

@egernst

Description of problem

Firecracker toml result in failure to boot. Since proxy.kata section exists in resulting toml, our config handling will try to resolve path, regardless of vsock utilization.

See:

if err := updateRuntimeConfig(resolved, tomlConf, &config, builtIn); err != nil {
		return "", config, err
	}

	config.DisableGuestSeccomp = tomlConf.Runtime.DisableGuestSeccomp

	// use no proxy if HypervisorConfig.UseVSock is true
	if config.HypervisorConfig.UseVSock {
		kataUtilsLogger.Info("VSOCK supported, configure to not use proxy")
		config.ProxyType = vc.NoProxyType
		config.ProxyConfig = vc.ProxyConfig{}
	}

https://github.com/kata-containers/runtime/blob/master/pkg/katautils/config.go#L942-L953

Expected result

proxy shouldn't be considered, since vsock is being used

Actual result

We check for proxy, based on existence of the table in toml, and fail

Suggestion

We can either augment updateRuntimeConfig to only check for proxy if !vsock, or update the default toml to remove the proxy section. I think just removing the proxy section in the toml.in makes most sense.

Metadata

Metadata

Assignees

Labels

bugIncorrect behaviourneeds-reviewNeeds to be assessed by the team.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions