Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

Remove legacy go import of github.com/containers/virtcontainers #140

@WeiZhang555

Description

@WeiZhang555

Description of problem

As we already moved github.com/containers/virtcontainers repository to github.com/kata-containers/runtime/virtcontainers, all virtcontainers dependencies should be moved to github.com/kata-containers/runtime/virtcontainers too.

But vendor/ dir still contains github.com/containers/virtcontainers as virtcontainers/container_test.go is referring to the wrong repo.

Other documents referring to virtcontainers should refer to new virtcontainers library too.

$ grep -nir "github.com/containers/virtcontainers" *
virtcontainers/mount.go:310:                    // See: https://github.com/containers/virtcontainers/issues/295
virtcontainers/container.go:779:        //TODO add support for memory, Issue: https://github.com/containers/virtcontainers/issues/578
virtcontainers/container.go:798:        //TODO add support for memory, Issue: https://github.com/containers/virtcontainers/issues/578
virtcontainers/hack/virtc/README.md:45:$ go get github.com/containers/virtcontainers
virtcontainers/hack/virtc/README.md:50:$ cd $GOPATH/src/github.com/containers/virtcontainers
virtcontainers/README.md:5:[![Go Report Card](https://goreportcard.com/badge/github.com/containers/virtcontainers)](https://goreportcard.com/report/github.com/containers/virtcontainers)
virtcontainers/README.md:7:[![GoDoc](https://godoc.org/github.com/containers/virtcontainers?status.svg)](https://godoc.org/github.com/containers/virtcontainers)
virtcontainers/README.md:212:2. Create the network namespace ([code](https://github.com/containers/virtcontainers/blob/0.5.0/cnm.go#L108-L120))
virtcontainers/README.md:214:3. Call the prestart hook (from inside the netns) ([code](https://github.com/containers/virtcontainers/blob/0.5.0/api.go#L46-L49))
virtcontainers/README.md:216:4. Scan network interfaces inside netns and get the name of the interface created by prestart hook ([code](https://github.com/containers/virtcontainers/blob/0.5.0/cnm.go#L70-L106))
virtcontainers/README.md:218:5. Create bridge, TAP, and link all together with network interface previously created ([code](https://github.com/containers/virtcontainers/blob/0.5.0/network.go#L123-L205))
virtcontainers/README.md:220:6. Start VM inside the netns and start the container ([code](https://github.com/containers/virtcontainers/blob/0.5.0/api.go#L66-L70))
virtcontainers/README.md:236:1. Create the network namespace ([code](https://github.com/containers/virtcontainers/blob/0.5.0/cni.go#L64-L76))
virtcontainers/README.md:238:2. Get CNI plugin information ([code](https://github.com/containers/virtcontainers/blob/0.5.0/cni.go#L29-L32))
virtcontainers/README.md:240:3. Start the plugin (providing previously created netns) to add a network described into /etc/cni/net.d/ directory. At that time, the CNI plugin will create the cni0 network interface and a veth pair between the host and the created netns. It links cni0 to the veth pair before to exit. ([code](https://github.com/containers/virtcontainers/blob/0.5.0/cni.go#L34-L45))
virtcontainers/README.md:242:4. Create bridge, TAP, and link all together with network interface previously created ([code](https://github.com/containers/virtcontainers/blob/0.5.0/network.go#L123-L205))
virtcontainers/README.md:244:5. Start VM inside the netns and start the container ([code](https://github.com/containers/virtcontainers/blob/0.5.0/api.go#L66-L70))

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions