Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

rootfs: install systemd tmp.mount if needed#319

Merged
jcvenegas merged 1 commit intokata-containers:masterfrom
marcov:debian-tmp.mount
Jun 20, 2019
Merged

rootfs: install systemd tmp.mount if needed#319
jcvenegas merged 1 commit intokata-containers:masterfrom
marcov:debian-tmp.mount

Conversation

@marcov
Copy link
Copy Markdown
Contributor

@marcov marcov commented Jun 20, 2019

On Debian / Ubuntu, tmp.mount is not installed in
/[etc|usr/lib]/systemd/system by default, but in
/usr/shared/systemd, and need to be manually copied there
to have /tmp mounted as tmpfs.

On some distros (Debian, Ubuntu, openSUSE), tmp.mount is not
installed by default in /[etc|usr/lib]/systemd/system, but
just in /usr/shared/systemd, so it needs to be manually copied
there to have /tmp mounted as tmpfs.

Fixes: #317

Signed-off-by: Marco Vedovati mvedovati@suse.com

@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

/test

@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

Cool, now it's the time for SUSE to fail with:

[\x1b[0;1;31mFAILED\x1b[0m] Failed to start chrony, an NTP client/server.

yak shaving at its finest 😼

@jodh-intel
Copy link
Copy Markdown

What? There is no yak emoji? What is the world coming to? 😞

@grahamwhaley
Copy link
Copy Markdown
Contributor

s/yak/🐃 /

@jodh-intel
Copy link
Copy Markdown

Cunning! So it's just github that lacks full animal support ;) Could it be described as being not a4l compliant? 😉

@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

Cool, now it's the time for SUSE to fail with:

[\x1b[0;1;31mFAILED\x1b[0m] Failed to start chrony, an NTP client/server.

Not sure about the error message, however what I see for SUSE images is that:

  • chronyd.service does not exist
  • tmp.mount is only installed in /usr/share/systemd, like for Debian.

@marcov marcov force-pushed the debian-tmp.mount branch from 592a8d6 to 7ca7f03 Compare June 20, 2019 15:09
@marcov marcov changed the title debian: install systemd tmp.mount needed by agent rootfs: install systemd tmp.mount if needed Jun 20, 2019
On some distros (Debian, Ubuntu, openSUSE), tmp.mount is not
installed by default in /[etc|usr/lib]/systemd/system, but
just in /usr/shared/systemd, so it needs to be manually copied
there to have /tmp mounted as tmpfs.

Fixes: kata-containers#317

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
@marcov marcov force-pushed the debian-tmp.mount branch from 7ca7f03 to 6969c7f Compare June 20, 2019 15:31
@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

/test

@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

ARM CI looks broken:

---------------------------

There are services installed on your system which need to be restarted when 
certain libraries, such as libpam, libc, and libssl, are upgraded. Since these 
restarts may cause interruptions of service for the system, you will normally be
prompted on each upgrade for the list of services you wish to restart.  You can 
choose this option to avoid being prompted; instead, all necessary restarts will
be done for you automatically so you can avoid being asked questions on each 
library upgrade.

Restart services during package upgrades without asking? [yes/no] Build timed out (after 10 minutes). Marking the build as aborted.
Build was aborted

@marcov
Copy link
Copy Markdown
Contributor Author

marcov commented Jun 20, 2019

Finally this looks promising, all yak's hair has been shaven 🎉

@kata-containers/builder I need some review, please

Copy link
Copy Markdown
Member

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jcvenegas jcvenegas merged commit 434418c into kata-containers:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI built debian images fail to start a container

5 participants