Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

image-builder/boot time: remove unneeded systemd units and files#290

Merged
jodh-intel merged 1 commit intokata-containers:masterfrom
devimc:topic/image/removeSystemdUnits
May 17, 2019
Merged

image-builder/boot time: remove unneeded systemd units and files#290
jodh-intel merged 1 commit intokata-containers:masterfrom
devimc:topic/image/removeSystemdUnits

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented May 16, 2019

Remove systemd units and files that are not needed in Kata Containers.
Removing this files we can improve the boot time.

fixes #289

1

before = with all systemd files and units
after = without unneeded systemd files and units (this patch)

cc @grahamwhaley @jodh-intel @bergwolf

Signed-off-by: Julio Montes julio.montes@intel.com

@devimc
Copy link
Copy Markdown
Author

devimc commented May 16, 2019

/test

@grahamwhaley
Copy link
Copy Markdown
Contributor

wow, ouch - now, that is the sort of graph we like to see @devimc :-)
Is this the best/only way for us to nuke those files - no method in the construction/installation of the distro/image I guess? Just asking, as the find/rm is a bit.. harsh.

Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devimc.

A few comments...

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
as long as nobody can think of any downsides... anything going away here that we rely on etc.

@devimc
Copy link
Copy Markdown
Author

devimc commented May 16, 2019

@grahamwhaley

Is this the best/only way for us to nuke those files - no method in the construction/installation of the distro/image I guess? Just asking, as the find/rm is a bit.. harsh.

I think so, because these files are part of the systemd rpm

Remove systemd units and files that are not needed in Kata Containers.
Removing this files we can improve the boot time.

fixes kata-containers#289

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc devimc force-pushed the topic/image/removeSystemdUnits branch from 875e593 to 02b3b3b Compare May 16, 2019 18:20
@devimc
Copy link
Copy Markdown
Author

devimc commented May 16, 2019

/test

Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks @devimc.

lgtm

@jodh-intel jodh-intel merged commit a800a5d into kata-containers:master May 17, 2019
@grahamwhaley
Copy link
Copy Markdown
Contributor

Heh, looks like we don't run the metrics CI on the osbuilder repo - I suspect the metrics CI might start failing now with this (positive) merge - and we'll maybe need an update PR'd to https://github.com/kata-containers/tests/blob/master/cmd/checkmetrics/ci_slaves/checkmetrics-json-kata-metric2.toml once we have gathered enough new data to set the new value.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unneeded systemd units

3 participants