tests: install kata components from master#243
tests: install kata components from master#243chavafg merged 1 commit intokata-containers:masterfrom
Conversation
|
/test |
fcd582a to
5eca0cb
Compare
|
/test |
5eca0cb to
e8f94f0
Compare
|
/test |
|
cc @jcvenegas |
| chronic $mgr install-docker-system | ||
| "${tests_repo_dir}/.ci/setup.sh" | ||
| mkdir -p /etc/kata-containers/ | ||
| sudo cp -a /usr/share/defaults/kata-containers/configuration.toml /etc/kata-containers/configuration.toml |
There was a problem hiding this comment.
Why is needed to copy /etc/kata-containers/ ?
There was a problem hiding this comment.
I think this is because the script makes use of the kata-manager.sh script elsewhere. And that script assumes you have a local /etc/kata-containers/configuration.toml file that it can make changes to.
| if [ -z "${KATA_DEV_MODE:-}" ]; then | ||
| chronic $mgr remove-docker | ||
| chronic $mgr install-docker-system | ||
| "${tests_repo_dir}/.ci/setup.sh" |
There was a problem hiding this comment.
There was a problem hiding this comment.
It's worth pointing out here the subtle distinction: the kata-manager.sh script installs packages built from master, whereas this PR is allowing components to be built from master (at the point before they are packaged ;)
There was a problem hiding this comment.
@jcvenegas no, install_kata.sh didn't work because there are a lot of build dependencies
| if [ -z "${KATA_DEV_MODE:-}" ]; then | ||
| chronic $mgr remove-docker | ||
| chronic $mgr install-docker-system | ||
| "${tests_repo_dir}/.ci/setup.sh" |
There was a problem hiding this comment.
It's worth pointing out here the subtle distinction: the kata-manager.sh script installs packages built from master, whereas this PR is allowing components to be built from master (at the point before they are packaged ;)
| chronic $mgr install-docker-system | ||
| "${tests_repo_dir}/.ci/setup.sh" | ||
| mkdir -p /etc/kata-containers/ | ||
| sudo cp -a /usr/share/defaults/kata-containers/configuration.toml /etc/kata-containers/configuration.toml |
There was a problem hiding this comment.
I think this is because the script makes use of the kata-manager.sh script elsewhere. And that script assumes you have a local /etc/kata-containers/configuration.toml file that it can make changes to.
e8f94f0 to
784bce9
Compare
|
/test |
784bce9 to
d564283
Compare
|
/test |
d564283 to
6bb3a51
Compare
|
/test |
6bb3a51 to
0d59ba3
Compare
|
/test |
0d59ba3 to
c1c9155
Compare
|
/test |
build and install kata containers components from master and run osbuilder tests. fixes kata-containers#242 Signed-off-by: Julio Montes <julio.montes@intel.com>
c1c9155 to
35588dd
Compare
|
/test |
|
One of the Travis jobs had stalled (the other passed), so I've restarted it... |
|
@jodh-intel thanks |
install kata containers components from master and run osbuilder tests
fixes #242
Signed-off-by: Julio Montes julio.montes@intel.com