Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Allow sharing of memory backend file#96

Merged
devimc merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:mem-hotplug-share
Jun 18, 2019
Merged

Allow sharing of memory backend file#96
devimc merged 1 commit intokata-containers:masterfrom
ganeshmaharaj:mem-hotplug-share

Conversation

@ganeshmaharaj
Copy link
Copy Markdown

Hotplugged memory could be backed by a file on the host with sharing
turned on. This change allows qmp to pass that option to a govmm.

Signed-off-by: Ganesh Maharaj Mahalingam ganesh.mahalingam@intel.com

Hotplugged memory could be backed by a file on the host with sharing
turned on. This change allows qmp to pass that option to a govmm.

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@markdryan
Copy link
Copy Markdown
Contributor

@bergwolf I think you may have originally added this function. Do these changes look okay to you?

Copy link
Copy Markdown
Member

@bergwolf bergwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ganeshmaharaj
Copy link
Copy Markdown
Author

Thanks @bergwolf

Copy link
Copy Markdown
Contributor

@markdryan markdryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 80.412% when pulling 0c900f5 on ganeshmaharaj:mem-hotplug-share into 516e0c5 on intel:master.

@devimc devimc merged commit 9f389cb into kata-containers:master Jun 18, 2019
@ganeshmaharaj ganeshmaharaj deleted the mem-hotplug-share branch June 18, 2019 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants