vendor: update vsock package version#551
Conversation
|
/test |
jodh-intel
left a comment
There was a problem hiding this comment.
Thanks for raising @marcov.
Please could you list the new commits this revendor pulls in using the git-log command here:
The vsock package needs go >= 1.11. The latest version of the package adds a
compile time check on the go version.
Shortlog since last vendoring of github.com/mdlayher/vsock:
7b7533a vsock: break compilation on unsupported versions of Go
75a9d2a go.mod: bump dependencies
7746c14 *: switch from Travis to builds.sr.ht exclusivel
Fixes: kata-containers#542
Signed-off-by: Marco Vedovati <mvedovati@suse.com>
|
done, thanks @jodh-intel |
|
/retest |
|
/retest |
|
/test |
|
@marcov We only require at least 1.10.4 (https://github.com/kata-containers/runtime/blob/master/versions.yaml#L267). Please update the runtime repo for the least required version. |
|
tag |
|
@bergwolf sure I can do that When building the rootfs, the agent's Go version is read from a file in osbuilder, so that should also be updated to use versions.yaml in the runtime repo. Actually I am not sure if the switch may break something. |
|
@marcov - which switch do you mean - changing osbuilder to look at the runtime's /cc @jcvenegas. |
|
@jodh-intel correct, it would require checking the versions.yaml file from the runtime repo instead of a local file in osbuilder. And I am not sure if having osbuilder depend on runtime repo (or on something in that repo), may pose a problem. |
|
I don't think it will cause problems, but then if not why did we create the separate |
|
In effect the golang binary is downloaded using |
|
kata-containers/runtime#1693 is merged |
The vsock package needs go >= 1.11. The latest version of the package adds a
compile time check on the go version.
Fixes: #542
Signed-off-by: Marco Vedovati mvedovati@suse.com