Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

agent: Display trace details#505

Merged
jodh-intel merged 1 commit intokata-containers:masterfrom
jodh-intel:log-trace-details
May 1, 2019
Merged

agent: Display trace details#505
jodh-intel merged 1 commit intokata-containers:masterfrom
jodh-intel:log-trace-details

Conversation

@jodh-intel
Copy link
Copy Markdown

@jodh-intel jodh-intel commented Mar 28, 2019

Log the trace mode and type when tracing is enabled. The change makes it clearer that static tracing is enabled when the agent parsers the kernel command line (config.go) and dynamic tracing is enabled by gRPC (grpc.go).

Specifics of change:

  • Rename variables to match the terms defined in TRACING.md.
  • Pass trace mode and trace type arguments to enableTracing().
  • Change the tense of the message displayed by enableTracing() so that the message indicates that tracing is enabled, not about to be.

Fixes #504.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Mar 28, 2019

/test

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Mar 28, 2019

@chavafg - the opensuse CI has fallen over with a Java exception - looks like git isn't installed maybe?:

Caused by: java.io.IOException: Cannot run program "git" (in directory "/tmp/jenkins/workspace/kata-containers-agent-opensuse-15-PR"): error=2, No such file or directory

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Apr 2, 2019

/retest

agent: Display trace details
2ada1d1 
Log the trace mode and type when tracing is enabled. The change makes it
clearer that static tracing is enabled when the agent parsers the kernel
command line (`config.go`) and dynamic tracing is enabled by gRPC (`grpc.go`).

Specifics of change:

- Rename variables to match the terms defined in `TRACING.md`.
- Pass trace mode and trace type arguments to `enableTracing()`.
- Change the tense of the message displayed by `enableTracing()` so that
  the message indicates that tracing *is* enabled, not *about to be*.

Fixes kata-containers#504.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Apr 16, 2019

Ping @kata-containers/agent.

/retest

@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Apr 16, 2019

CI 18.04 failed with a net/quay error - I'll nudge that one, and we'll see if that clears. I've not looked at the other fails (I'm just going to presume they are similar for now).

Ensure docker service is stopped before running the tests
time="2019-04-16T12:11:09Z" level=error msg="error copying docker://quay.io/crio/redis:alpine to dir:/tmp/jenkins/workspace/kata-containers-agent-ubuntu-18-04-PR/go/src/github.com/cri-o/cri-o/.artifacts/redis-image: Error determining manifest MIME type for docker://quay.io/crio/redis:alpine: pinging docker registry returned: Get https://quay.io/v2/: EOF" 
Error pulling quay.io/crio/redis
Makefile:76: recipe for target 'crio' failed
make: *** [crio] Error 1
Build step 'Execute shell' marked build as failur

grahamwhaley
grahamwhaley approved these changes Apr 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Apr 16, 2019

Looks like something got wedged upstream:

time="2019-04-16T12:24:39Z" level=error msg="error copying docker://quay.io/crio/redis:alpine to dir:/tmp/jenkins/workspace/kata-containers-agent-ubuntu-nemu/go/src/github.com/cri-o/cri-o/.artifacts/redis-image: Error determining manifest MIME type for docker://quay.io/crio/redis:alpine: pinging docker registry returned: Get https://quay.io/v2/: EOF" 
13:24:39 Error pulling quay.io/crio/redis
13:24:39 Makefile:76: recipe for target 'crio' failed
13:24:39 make: *** [crio] Error 1

time="2019-04-16T12:09:33Z" level=error msg="error copying docker://quay.io/crio/redis:alpine to dir:/tmp/jenkins/workspace/kata-containers-agent-centos-7-4-q-35-PR/go/src/github.com/cri-o/cri-o/.artifacts/redis-image: Error determining manifest MIME type for docker://quay.io/crio/redis:alpine: pinging docker registry returned: Get https://quay.io/v2/: EOF" 
Error pulling quay.io/crio/redis

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented Apr 16, 2019

/me puts a coin in the slot and re-cranks...

@gabibeyer
Copy link
Copy Markdown

gabibeyer commented Apr 30, 2019

/test

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented May 1, 2019

Power CI failing with a weird message:

[WS-CLEANUP] Deferred wipeout is disabled by the job configuration...
ERROR: [WS-CLEANUP] Cannot delete workspace: Unable to delete '/home/jenkins/workspace/kata-containers-agent-Power8-ubuntu-16-04-PR-initrd/go/pkg/linux_ppc64le/github.com/kata-containers/tests/vendor/github.com/BurntSushi/toml.a'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

/cc @nitkon

@nitkon
Copy link
Copy Markdown
Contributor

nitkon commented May 1, 2019 •
edited
Loading

@jodh-intel : Cleared the workspace and reran the CI. Now It is failing because of E: Version '' for 'docker-ce' was not found

Edit: apt-cache madison docker-ce returns nothing on the Ubuntu 1604 CI server.
Another point is : arch=$(go env GOARCH) returns ppc64le but when installing docker, https://docs.docker.com/install/linux/docker-ce/ubuntu/, "deb [arch=ppc64el] https://download.docker.com.." should be used.

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented May 1, 2019

Thanks @nitkon. Hmm, could that be because of this...

@jodh-intel
Copy link
Copy Markdown
Author

jodh-intel commented May 1, 2019

@nitkon - can you possibly raise an issue for the ppc64 issue? I'm going to merge this as that's the only failure which is unrelated to this change...

@jodh-intel jodh-intel merged commit 629f90f into kata-containers:master May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@devimc devimc devimc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Display trace details

5 participants

@jodh-intel @grahamwhaley @gabibeyer @nitkon @devimc