agent: auto-online hotplug memory#364
Conversation
Kata agent does not wait for memory hotplug, and kata-runtime does not wait on cpu/memory online. As a temporary fix, let's make sure memory are onlined by the uevent listener at least. Fixes: kata-containers#363 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 47.21% 46.91% -0.31%
==========================================
Files 15 15
Lines 2442 2413 -29
==========================================
- Hits 1153 1132 -21
+ Misses 1140 1137 -3
+ Partials 149 144 -5 |
|
nice |
|
cc @clarecch @linzichang |
sboeuf
left a comment
There was a problem hiding this comment.
Looks good to me, but please split into 2 commits.
| // We only care about add event | ||
| if uEv.Action != "add" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Please put this in a separate commit, as this is not related to the uevent for memory.
There was a problem hiding this comment.
Why ask for splitting a commit into two? The checks MUST be separated otherwise I have to check it again when testing for memory online path.
|
|
||
| // Check if device hotplug event results in a device node being created. | ||
| if uEv.DevName != "" && uEv.Action == "add" && strings.HasPrefix(uEv.DevPath, rootBusPath) { | ||
| if uEv.DevName != "" && strings.HasPrefix(uEv.DevPath, rootBusPath) { |
There was a problem hiding this comment.
Same thing here, this should go to a separate commit.
There was a problem hiding this comment.
Same here. It IS a single commit.
|
I have a question. Will this face the same question I found at kata-containers/runtime#624 (comment) ? |
|
@linzichang Are you referring to the systemd udev issue? For one thing, the commit does not make things worse and it actually fixes the |
|
@bergwolf The main issue is |
|
Travis is stuck as for a bunch of other PRs. Ignoring for now and merging this |
Kata agent does not wait for memory hotplug, and kata-runtime
does not wait on cpu/memory online. As a temporary fix, let's
make sure memory are onlined by the uevent listener at least.
Fixes: #363