Migrate to versions catalog#224
Merged
kasem-sm merged 4 commits intoOct 16, 2022
Merged
Conversation
Owner
|
Hey @indyfromoz, I see that you did a great job of cleaning up the Thank you for your current contribution 🥇 |
Contributor
Author
|
Hello @kasem-sm! Thank you for reviewing my PR and really appreciate your help & comments. |
Contributor
Author
|
@kasem-sm Added a new commit for the suggested change. I will investigate a way to set SDK versions in a better way. Kindly review the changes. |
Owner
|
Thank you for your contribution. ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the project setup to add a dependency versions catalog and update the configuration based on the new catalog. I have split the changes to three separate commits to aid with the code review.
Some notes -
bundlesbut in the Gradle files but there are no major benefits as bundles could include only 1 or 2 dependencies.jvmargsas the compiler was throwing a out of memory exception. Happy to revert the changes if it is not acceptable.build.gradlefiles into Kotlin script in the future.I have compiled the app with
Android Studio Dolphin | 2021.3.1.Patch1and tested on a Pixel 6/Android 12 device.Could you please review the changes?
Closes #155