fix(reporter): set exit code when thresholds aren't met#420
Closed
matz3 wants to merge 2 commits intokarma-runner:masterfrom
Closed
fix(reporter): set exit code when thresholds aren't met#420matz3 wants to merge 2 commits intokarma-runner:masterfrom
matz3 wants to merge 2 commits intokarma-runner:masterfrom
Conversation
This was referenced Jul 23, 2020
Author
|
Fixed existing tests. New tests for |
anthony-redFox
requested changes
Jul 23, 2020
|
|
||
| this.onExit = function (done) { | ||
| this.onExit = function (exitDone) { | ||
| const done = () => { |
Collaborator
There was a problem hiding this comment.
Custom done can be execute with 1 or 0. I think, it is regression
Author
There was a problem hiding this comment.
As of now, the onExit done callback from karma-runner doesn't expect any value. This is a new feature proposal from my PR (karma-runner/karma#3541). So I don't understand how this can be a regression.
I don't know how the _onExit is used or how implements it. But I expected it to be a hook for some third-party and I intentionally did not allow it to provide an exit code value.
Author
|
Already solved with #419 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #418