fix(file-list): revert "do not preprocess up-to-date files" (#3226)#3230
Merged
johnjbarton merged 1 commit intokarma-runner:masterfrom Dec 6, 2018
segrey:fix-3226
Merged
fix(file-list): revert "do not preprocess up-to-date files" (#3226)#3230johnjbarton merged 1 commit intokarma-runner:masterfrom segrey:fix-3226
johnjbarton merged 1 commit intokarma-runner:masterfrom
segrey:fix-3226
Conversation
This reverts commit 5334d1a karma-webpack preprocessor updates bundle when needed, but karma's fileList consists of a single entry file which is usually unmodified. In this case, fileList.refresh() should always call preprocessor for the single entry file, avoiding preprocessing of unmodified files is done on karma-webpack side.
johnjbarton
approved these changes
Dec 6, 2018
Contributor
johnjbarton
left a comment
There was a problem hiding this comment.
Thanks for following up!
Contributor
Author
|
@johnjbarton Thanks for the quick turnaround. Sorry for the regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5334d1a
karma-webpack preprocessor updates bundle when needed, but karma's fileList consists of a single entry file which is usually unmodified. In this case, fileList.refresh() should always call preprocessor for the single entry file, avoiding preprocessing of unmodified files is done on karma-webpack side.