Conversation
Adds an admonition warning users not to close WaterDrop producers from within their own notification callbacks (e.g., message.acknowledged, statistics.emitted). When using FD polling mode, these callbacks execute on the poller thread, and closing the producer from within can cause synchronization issues or deadlocks. Related to: karafka/waterdrop#780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message.acknowledgedandstatistics.emittedexecute on the poller thread, and closing the producer from there can lead to synchronization issues or deadlocksTest plan
npm run lint)