Conversation
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to build the Astro static site and deploy the generated dist artifact to GitHub Pages.
Changes:
- Introduces a two-job Pages pipeline:
build(install + build + upload artifact) anddeploy(deploy artifact to Pages). - Configures Node.js (v22) with npm caching and sets required GitHub Pages permissions/concurrency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| on: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
on.push.branches is set to master, but this repo appears to use main as the base branch (see PR diff header index main..branch). As-is, this workflow likely won't run on normal pushes. Update the branch filter to main (or include both main and master if needed).
| branches: [master] | |
| branches: [main, master] |
| node-version: 22 | ||
| cache: npm | ||
|
|
||
| - run: npm install |
There was a problem hiding this comment.
This uses npm install even though a package-lock.json is present. In CI, prefer npm ci for deterministic installs and faster, more reliable builds (it will fail if the lockfile is out of sync).
| - run: npm install | |
| - run: npm ci |
No description provided.