Skip to content

Add root (/) endpoint with basic status response#26

Merged
em3s merged 3 commits intokakao:mainfrom
jaideepkathiresan:issue-25-add-root-endpoint
Jan 12, 2026
Merged

Add root (/) endpoint with basic status response#26
em3s merged 3 commits intokakao:mainfrom
jaideepkathiresan:issue-25-add-root-endpoint

Conversation

@jaideepkathiresan
Copy link
Copy Markdown
Contributor

@jaideepkathiresan jaideepkathiresan commented Jan 10, 2026 •
edited
Loading

Summary of Changes

Added RootController.kt

  • Added a new controller to handle GET / requests.
  • Returns a lightweight JSON response containing:
    1. Service status
    2. Current version
    3. Timestamp

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 10, 2026
@jaideepkathiresan
Copy link
Copy Markdown
Contributor Author

jaideepkathiresan commented Jan 10, 2026

Hi @em3s, this is my first time contributing to this repo. Could you kindly test this PR and let me know your feedback or any suggestions? Thank-you!

em3s
em3s requested changes Jan 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@em3s em3s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! @jaideepkathiresan

I tested this PR locally and it works as expected.
The implementation looks clear and straightforward.

I have one small request:

  • Please change the fallback value from "0.1.0" to "unknown" as reviewed above.

Once this change is applied, I’ll be happy to merge the PR.

FYI, the CI is currently failing, but it passes locally, so this may be related to our CI setup.
cc @eazyhozy — please check the CI settings when you have time.

@jaideepkathiresan
Copy link
Copy Markdown
Contributor Author

jaideepkathiresan commented Jan 10, 2026

Hi @em3s, thanks for the positive feedback. I’ve also incorporated the suggested changes. Could you please test the latest commit and let me know?

@em3s
Copy link
Copy Markdown
Contributor

em3s commented Jan 12, 2026

Thank you for updating the requirements, @jaideepkathiresan.

The CI failure was caused by a Spotless formatting issue, and the CI output didn’t make this very clear.

I’ll run ./gradlew spotlessApply on our side and update the contributing/docs so this can be caught locally in the future.

Thanks again for your first contribution!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 12, 2026
@em3s em3s merged commit 64e64cb into kakao:main Jan 12, 2026
2 checks passed
@em3s em3s changed the title feat(api): add root (/) endpoint with basic status response (#25) feat(api): add root (/) endpoint with basic status response Jan 12, 2026
@em3s em3s added the first-time contributor First-time contributor to this repository label Jan 29, 2026
@em3s em3s changed the title feat(api): add root (/) endpoint with basic status response Add root (/) endpoint with basic status response Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@em3s em3s em3s approved these changes

Assignees

@jaideepkathiresan jaideepkathiresan

Labels

enhancement New feature or request first-time contributor First-time contributor to this repository lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Root (/) Endpoint with Basic Status Response

2 participants

@jaideepkathiresan @em3s