Skip to content

V3MutationService and V3CompatibleTableBinding - gpt-oss#198

Closed
em3s wants to merge 1 commit intomainfrom
feat/issue-195-refactor-v3mutationservice-and-v3compatibletablebinding
Closed

V3MutationService and V3CompatibleTableBinding - gpt-oss#198
em3s wants to merge 1 commit intomainfrom
feat/issue-195-refactor-v3mutationservice-and-v3compatibletablebinding

Conversation

@em3s
Copy link
Copy Markdown
Contributor

@em3s em3s commented Feb 9, 2026

Summary

Refactor V3MutationService and V3CompatibleTableBinding to eliminate duplicate code and fix bug in mutateMultiEdge handling of LockAcquisitionFailedException.

Closes #195

Plan

Created by opencode (gpt-oss-120b)

  • Extract buildHBaseMutations() private helper in V3CompatibleTableBinding (identical HBase mutation construction)
    • Extract decodeCurrentState() private helper in V3CompatibleTableBinding (identical state decoding logic)
  • Extract resolveMutationContext() private helper in V3MutationService (label validation + context initialization)
  • Extract writeCdc() private helper in V3MutationService (CDC message creation + publish)
  • Extract handleMutationError() private helper and apply to both mutateEdge and mutateMultiEdge methods
  • Add onErrorResume for LockAcquisitionFailedException to mutateMultiEdge (consistent error handling)

Progress

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 9, 2026
@em3s em3s changed the title Refactor V3MutationService and V3CompatibleTableBinding to eliminate duplicate code refactor(engine): V3MutationService and V3CompatibleTableBinding - gpt-oss Feb 9, 2026
@em3s
Copy link
Copy Markdown
Contributor Author

em3s commented Feb 9, 2026

gpt-oss-120b (OpenCode) fails, while Codex work fine.

@em3s em3s closed this Feb 9, 2026
@em3s em3s changed the title refactor(engine): V3MutationService and V3CompatibleTableBinding - gpt-oss V3MutationService and V3CompatibleTableBinding - gpt-oss Feb 12, 2026
@em3s em3s deleted the feat/issue-195-refactor-v3mutationservice-and-v3compatibletablebinding branch March 1, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor V3MutationService and V3CompatibleTableBinding to eliminate duplicate code

1 participant