Make V3 metadata CRUD tests self-contained and expand lifecycle coverage#190
Merged
Make V3 metadata CRUD tests self-contained and expand lifecycle coverage#190
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…3 Metadata tests Remove @TestMethodOrder(OrderAnnotation) and @order(N) from CRUD lifecycle tests. Each test now carries its own precondition data via @ObjectSource fields — update creates first, delete creates+deactivates first. Use `shared` for common payloads (deactivate: {"active": false}). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Review Round 1by claude code (opus 4.6) Issues Found & Fixed
ResultAll tests passing (107/107). No CRITICAL/HIGH issues. One WARNING fixed. |
…coverage - Database: add deactivate, reactivate, delete tests (previously missing) - Table: add reactivate test - Alias: add reactivate test - All use shared preconditions (deactivate/reactivate payloads via shared) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Review Round 2by opencode (gpt-5.3-codex) Issues Found & Fixed
ResultTargeted tests passed for affected suites; no CRITICAL/HIGH issues remain. |
Contributor
Author
|
Reviewed
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor V3 metadata CRUD tests to be fully self-contained by removing execution-order dependency (
@TestMethodOrder+@Order) and embedding preconditions in each case via@ObjectSource.Also expand lifecycle coverage by adding/clarifying deactivate, reactivate, and delete scenarios across database/table/alias metadata tests.
What Changed
create, plusdeactivate/reactivatewhere needed)shared/casesin@ObjectSourceto reduce duplicated lifecycle payloadsDatabaseControllerTestTableControllerTestAliasControllerTestWhy
The previous ordered approach depended on cross-test state and execution sequence.
With
@ObjectSourceshared/casessupport, each test now declares its own setup and assertion path, improving isolation, readability, and maintainability.Plan
Created by claude code (opus 4.6)
DatabaseControllerTest— remove@Order, add self-contained preconditionsTableControllerTest— remove@Order, add self-contained preconditionsAliasControllerTest— remove@Order, add self-contained preconditionsProgress