Conversation
- Add MultiEdgeQueryController with GET/POST /multi-edges/ids endpoint - Add V3QueryService.gets(ids) overload for multi-edge id-based lookup - Extract common logic to private getsByKeys() method - Add MultiEdgeIdsRequest payload class - Add comprehensive tests for gets with ids functionality The gets(ids) overload allows efficient retrieval of multiple multi-edges by their ids in a single request, avoiding the N×M combination overhead of the gets(source, target) method when only id-based lookup is needed.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@YoonSung LGTM 👍 This looks like a solid starting point for multi-edge mget. The refactoring to extract Nit: Removed some unnecessary formatting changes. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Multi-Edge batch query API that retrieves edges by their IDs directly, optimizing the N×M combinations in unique-edge
getsby querying multi-edges withsource=id, target=idpattern.Closes #
Changes
MultiEdgeQueryControllerwith GET/POST/multi-edges/idsendpointsMultiEdgeIdsRequestpayload class for POST request bodygets(ids)overload inV3QueryServicefor multi-edge batch retrievalgets(source, target)to delegate to privategetsByKeys()methodMultiEdgeSpec.ktHow to Test