Skip to content

Fix 32-bit compilation errors#30

Merged
kahing merged 1 commit intokahing:masterfrom
gaul:32-bit
Mar 21, 2020
Merged

Fix 32-bit compilation errors#30
kahing merged 1 commit intokahing:masterfrom
gaul:32-bit

Conversation

@gaul
Copy link
Collaborator

@gaul gaul commented Jan 23, 2020

This allows tests to pass on Raspberry Pi. Upgrade libc crate to get
access to some 64-bit variants. Fixes #14.

@gaul gaul requested a review from kahing January 25, 2020 03:09
@gaul
Copy link
Collaborator Author

gaul commented Jan 25, 2020

Can use off64_t, pwrite64, etc. to fix large files.

@gaul
Copy link
Collaborator Author

gaul commented Jan 25, 2020

Updated to use 64-bit variants.

@gaul
Copy link
Collaborator Author

gaul commented Feb 29, 2020

This is the right thing to do but it will further break macOS support since the platform lacks the *64 libc variants. Will need to follow up after merging.

This allows tests to pass on Raspberry Pi.  Upgrade libc crate to get
access to some 64-bit variants.  Fixes kahing#14.
@gaul
Copy link
Collaborator Author

gaul commented Mar 17, 2020

It looks like Travis failed for reasons unrelated to this pull request. I opened #43.

@kahing kahing merged commit 1f81780 into kahing:master Mar 21, 2020
@gaul gaul deleted the 32-bit branch March 22, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

32 bits build is broken

2 participants