Update controller manifests + add CI check to prevent drift #1132
Conversation
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR synchronizes controller manifests/CRDs that had drifted out of date and introduces a new CI check to prevent future drift. The changes regenerate the ModelConfig CRD to add the kagent category classification and a new TLS validation rule, while the CI workflow ensures these generated files stay in sync with their source code.
Key changes:
- Adds
manifests-checkCI job that validates controller manifests are up-to-date by runningmake controller-manifestsand checking for uncommitted changes - Regenerates ModelConfig CRD files to add
kagentcategory and an additionalcaCertSecretKeyvalidation rule
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Adds new manifests-check job to prevent manifest drift by validating generated files are committed |
| go/config/crd/bases/kagent.dev_modelconfigs.yaml | Updates ModelConfig CRD with kagent category and additional TLS validation rule |
| helm/kagent-crds/templates/kagent.dev_modelconfigs.yaml | Updates Helm template with identical changes to maintain consistency with base CRD |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Seems like my newly added CI check is failing because when run on CI, the categories are being removed 🤔 |
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Fixed in c75ec38 |
Noticed yesterday that the controllers manifests/CRDs were out of date - although it seems like these have since been updated (at least somewhat) by #1111. This PR regenerates them once again and also adds a CI check to try prevent them from drifting.
Side Note: I've noticed that the category
kagentseems to be being constantly added/removed - not sure why this is happening but we should probably look into that.