fixed the tools desciption bug #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: killjoycircuit <rutujdhawale@gmail.com>
peterj
reviewed
Nov 1, 2025
ui/src/app/models/new/page.tsx
Outdated
| // const response = await getModelConfig( | ||
| // k8sRefUtils.toRef(modelConfigNamespace || '', modelConfigName) | ||
| // ); | ||
| // if (!isMounted) return; |
peterj
requested changes
Nov 1, 2025
Collaborator
peterj
left a comment
There was a problem hiding this comment.
there's a lot of code that's commented out
removed commented part Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
removed commented part Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
removed commented out part Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
removed commented part Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
Removed commented out code Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
peterj
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes(ui): correct tool descriptions and agent card display issues
-Changed server reference comparison from partial name matching to full reference matching, ensuring tools display their correct descriptions and prevent adding the same tool multiple times
-Resolved AgentCard overlay interfering with model name visibility
Fixes incorrect tool descriptions in ToolsSection and SelectToolsDialog components, and improves AgentCard UI rendering.
Closes issue #1003