Return error instead of panic for invalid regex in definition

kachick · kachick · commit d9e786bce4a7 · 2026-02-09T21:00:09.000+09:00
diff --git a/internal/runner/runner.go b/internal/runner/runner.go
@@ -76,7 +76,10 @@ func DryRun(r io.Reader, prefix *regexp.Regexp, skipBy string) (Result, error) {
 		if err != nil {
 			return Result{}, xerrors.Errorf("%d: Unmarsharing `%s` as JSON has been failed, check the given prefix: %w", lineNumber, jsonStr, err)
 		}
-		extractor := regexp.MustCompile(def.Extract)
+		extractor, err := regexp.Compile(def.Extract)
+		if err != nil {
+			return Result{}, xerrors.Errorf("%d: Invalid regex `%s`: %w", lineNumber, def.Extract, err)
+		}
 		if len(def.Command) < 1 {
 			return Result{}, xerrors.Errorf("%d: Given JSON `%s` does not include commands", lineNumber, jsonStr)
 		}
diff --git a/internal/runner/runner_test.go b/internal/runner/runner_test.go
@@ -158,6 +158,13 @@ broken: ':<' # selfup { "extract": ":[<\\)]", "replacer": ["this_command_does_no
 		}, "Broken JSON": {
 			input: `Header
 broken: ':<' # selfup {{ """" }
+`,
+			prefix: defaultPrefix,
+			skipBy: "",
+			ok:     false,
+		}, "Invalid Regex": {
+			input: `Header
+broken: '0.1.0' # selfup { "extract": "[", "replacer": ["echo", "0.2.0"] }
 `,
 			prefix: defaultPrefix,
 			skipBy: "",

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,10 @@ func DryRun(r io.Reader, prefix *regexp.Regexp, skipBy string) (Result, error) {`
`76`	`76`	`if err != nil {`
`77`	`77`	return Result{}, xerrors.Errorf("%d: Unmarsharing `%s` as JSON has been failed, check the given prefix: %w", lineNumber, jsonStr, err)
`78`	`78`	`}`
`79`		`- extractor := regexp.MustCompile(def.Extract)`
	`79`	`+ extractor, err := regexp.Compile(def.Extract)`
	`80`	`+ if err != nil {`
	`81`	+ return Result{}, xerrors.Errorf("%d: Invalid regex `%s`: %w", lineNumber, def.Extract, err)
	`82`	`+ }`
`80`	`83`	`if len(def.Command) < 1 {`
`81`	`84`	return Result{}, xerrors.Errorf("%d: Given JSON `%s` does not include commands", lineNumber, jsonStr)
`82`	`85`	`}`