Fix test_remote_io.py due to mutating public s3 bucket (#997)#3
Merged
kace merged 1 commit intokace:torchdata_pt_1.12.1from Feb 9, 2023
Merged
Conversation
) Summary: Please read through our [contribution guide](https://github.com/pytorch/data/blob/main/CONTRIBUTING.md) prior to creating your pull request. - Note that there is a section on requirements related to adding a new DataPipe. Fixes meta-pytorch#984 - Add a private function to TestDataPipeRemoteIO in test_remote_io.py to get s3 objects count label through aws cli - add awscli in requirements Pull Request resolved: meta-pytorch#997 Reviewed By: ejguan Differential Revision: D43157757 Pulled By: NivekT fbshipit-source-id: 7e9ee8299a28a087f88024c3b3e77be3bfe5adf0
kace
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Please read through our contribution guide prior to creating your pull request.
Fixes meta-pytorch#984
Pull Request resolved: meta-pytorch#997
Reviewed By: ejguan
Differential Revision: D43157757
Pulled By: NivekT
fbshipit-source-id: 7e9ee8299a28a087f88024c3b3e77be3bfe5adf0
Please read through our contribution guide prior to
creating your pull request.
Fixes #{issue number}
Changes