Merged
Conversation
aa0cb4c to
e9fd617
Compare
|
SourceLevel has finished reviewing this Pull Request and has found:
|
Member
Author
|
The behaviour is different when passing an empty secret to the HMAC signing because of openssl/openssl#13089 Just marked the tests as pending for openssl 3 |
a72a4e4 to
d4db08f
Compare
Member
Author
|
Im going to trust the tests and merge this one. It works at least better than the current version... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.0 is taking over and that brings some compatibility challenges to gems like this. Related to #495.
https://github.com/ruby/openssl/blob/master/History.md#compatibility-notes
The change that has the most impact on the ruby-jwt gem is that the key and keypairs that are created using openssl is not mutable anymore. Before the Ruby openssl gem provides some nicer API to generate them based on the raw parameters we need to generate the ASN.1 sequences and have them as the base for creating the key objects.