Update to winit/glutin EventLoop 2.0 by chrisduerr · Pull Request #2438 · alacritty/alacritty

chrisduerr · 2019-05-13T20:56:39Z

This takes the latest glutin master to port Alacritty to the EventLoop
2.0 rework.

This changes a big part of the event loop handling by pushing the event
loop in a separate thread from the renderer and running both in
parallel.

TODO:

Fixes #2796.
Fixes #2694.
Fixes #2643.
Fixes #2625.
Fixes #2618.
Fixes #2601.
Fixes #2564.
Fixes #2456.
Fixes #2438.
Fixes #2334.
Fixes #2254.
Fixes #2217.
Fixes #1789.
Fixes #1750.
Fixes #1125.

Osspial · 2019-05-14T04:21:09Z

Heads up with using process_events to call into Winit via run_return: doing so will cause Alacritty's event loop to freeze during window resizes on Windows. For some godforsaken reason, Windows takes over the application's control flow when resize operations occur, preventing run_return from returning until the resize is complete. We've been hiding that in the past by spawning a background thread to run the OS event loop, but that has been removed in the EL2.0 code since it fixes Several Bugs on all platforms where we do it.

(Those issues may happen on macOS as well, but I'm way less familiar with that backend so I can't say so with much certainty.)

cole-h · 2019-05-14T05:17:41Z

Don't know if you're already aware of this, but: running this branch on Wayland with cargo +stable run -- --print-events (building on v1.31.0 gives 2 errors from glutin) shows an infinitely repeating spam of the following:

[2019-05-13 21:46] [INFO] glutin event: EventsCleared
[2019-05-13 21:46] [INFO] glutin event: LoopDestroyed
[2019-05-13 21:46] [INFO] glutin event: NewEvents(Init)
[2019-05-13 21:46] [INFO] glutin event: LoopDestroyed
[2019-05-13 21:46] [INFO] glutin event: NewEvents(Init)
[2019-05-13 21:46] [INFO] glutin event: EventsCleared
[2019-05-13 21:46] [INFO] glutin event: LoopDestroyed

~~Running with WAYLAND_DISPLAY= cargo +stable run -- --print-events shows events properly captured with Xwayland.~~

~~cargo run --example window in glutin (defaulted to v1.35.0) shows events properly firing as well.~~

EDIT: See below. Sorry for the noise.

chrisduerr · 2019-05-14T14:13:40Z

@Osspial Doesn't that make it effectively impossible to use run_return? It seems like that's a pretty major limitation, either you accept freezing or run_return becomes pointless, right?

Is the recommendation for desktop platforms to just ignore it and accept freezing during resize? Or what's the idea here for consumers to do?

chrisduerr · 2019-05-14T14:14:47Z

@cole-h Those are the proper events. This is intentional since we're using run_return and not run. The glutin example does not use the desktop extension and run_return.

Osspial · 2019-05-16T03:59:37Z

@chrisduerr The idea is to use run and have Winit drive the application's event loop. run_return was mainly added because... well, it's easy to add, and the current way we implement the ! return value on desktops isn't particularly clean (it uses std::process:exit() to tear everything down).

The documentation should be more clear about what its limitations are, since it isn't so much a replacement for poll_events as much as it is a use if you can't have the process terminate itself when the event loop is over.

chrisduerr · 2019-05-16T14:31:46Z

@Osspial At that point, why not have run just take self and consume the event loop? Then you probably won't have to exit automatically either, right? Since it's not possible to use the event loop after it has been consumed.

I personally find it a bit questionable when a library calls exit anyways, so usually that seems like the better approach in my opinion. Currently I don't see how anyone would use the API properly without causing any issues.

Not having a replacement for poll_events is also quite unfortunate, since it basically requires all applications to have separate threads and likely force them into additional locking and similar troubles. I personally find the usual Rust channel API very nice because of that, with both blocking methods (recv) and non-blocking alternatives (try_recv).

Osspial · 2019-05-18T04:20:49Z

@chrisduerr We have it return ! to maintain cross-platform compatibility - we fundamentally can't return a value on mobile and web platforms, so std::process::exit is used so we can expose the same API across platforms.

I agree - it is unfortunate that we have to do away with poll_events! However, the only platform it can be implemented on, and behave as expected, is Linux: Windows and macOS have the above freezing issues, and every other platform flat-out doesn't work with an event polling model. With those caveats, it doesn't make a whole lot of sense to expose it as an API.

Not having a replacement for poll_events is also quite unfortunate, since it basically requires all applications to have separate threads and likely force them into additional locking and similar troubles.

What do you mean by that? The new EventLoop API should be perfectly sufficient for driving a desktop application like Alacritty - ControlFlow has been significantly improved from its old version, and should be more than enough for your purposes.

chrisduerr · 2019-05-18T05:37:44Z

What do you mean by that? The new EventLoop API should be perfectly sufficient for driving a desktop application like Alacritty - ControlFlow has been significantly improved from its old version, and should be more than enough for your purposes.

Alacritty currently runs the event loop in the main thread. This obviously wouldn't work anymore. However I do want to say that if winit would spawn a separate thread anyways, giving the consumer the choice how to setup that thread and synchronize it isn't necessarily a bad thing, since it gives more control.

@Osspial Do you think it would be possible to remove run_return completely? Right now it feels to me like it's more of a pitfall than anything else. Unless the event loop quits by itself automatically when the window is closed, it should be possible to just keep it running indefinitely if you don't want to exit your program after the window has been closed. I feel like it would be easier to just completely remove run_return rather than having it broken.

da-x · 2019-05-26T10:49:50Z

I have a very reproducible instance of the #824 issue, and I want to test this PR to see that it fixes it. However fix-desktop-module branch does not exist any more in chrisduerr/glutin and the build fails. Can you please fix this? Thanks.

chrisduerr · 2019-05-26T11:03:17Z

@da-x I'm currently reworking a large chunk of the PR, I'll update whenever that is ready.

Osspial · 2019-05-28T02:46:35Z

@chrisduerr That shouldn't be too hard to do. However, I'm more inclined to explicitly document its pitfalls in the function documentation rather than remove it, so that the tool is still available for people that absolutely need to use it.

nixpulvis · 2019-06-01T14:31:00Z

+
+- Opacity not live changing anymore?
+- Signal handling broken (ctrl+c doesn't work?)
+- Clean up EventLoops, maybe merge Alacritty's and Glutin's together somehow?


This sounds like a potential nice win.

kchibisov · 2019-06-03T14:19:01Z

I've ran this PR for sometime and noticed that input with high key repeat rate is "jerky" compared to master. You can test it with xset r rate 200 60 and scroll neovim with (j,k) or just hold key in shell prompt (I've testing this with bash/fish).

chrisduerr · 2019-06-03T15:04:43Z

@kchibisov Can you reproduce this jerkiness with the glutin examples? Or is the output more consistent there?

kchibisov · 2019-06-03T16:39:02Z

@chrisduerr , sorry, if I wrote it unclear. I've tried it with glutin examples, but I didn't find anything suitable, since all of them are just a bunch of triangles and the issue is caused by io from keyboard ( The output of tree / is super smooth and consistent as before and time is the ~same). It seems like under high key repeat rate cursor sometimes is drawing slightly behind text and then updates, this causes jerkiness in neovim, when scrolling with j and '`k. To be clear, the output is always consistent, but sometimes it feels like screen or cursor shaking ( this is just my "eyes" feeling).

This is all on HiDPI screen and on X11, compositor(compton) was disabled during tests.

chrisduerr · 2019-06-03T16:41:46Z

Just to be absolutely clear, you don't see this behavior with the latest master, right? Cursor drawing behind text sounds extremely odd, since those should be both updated at the same time.

kchibisov · 2019-06-03T17:30:17Z

Yes, it doesn't happen on the latest master. I've looked more precisely on cursor and it seems like it's on 2 cells in the same time ( disappearing on previous cell ( according to cursor motion) and solid on the current). Also I've just noticed that sometimes input is missing and it become consistent after key release.

Master to this branch comparison with repeat rate I've mentioned earlier:
On master: Everything smooth, but sometime cursor slowdown a bit ( it happens in every app on my pc with such repeat rate, so it's ok).
This PR: It seems like this slowdown is missing, but the problems mentioned above appears.

I'll do screen recording if you can't reproduce or it's unclear, but it'll take time.

Update
io scheduler - bfq(tuned for low io latency).

kchibisov · 2019-06-03T18:21:11Z

@chrisduerr one more thing that can help. If you open 2 terminals ( built from this PR), launch tmux and attach to the same session, input "lags" in one of them results in lags in another, but if you run alacritty from master and alacritty from this PR, do the same thing with tmux, and input in good, terminal everything will be fine in 'bad' terminal, and if you input in bad terminal, everything will be broken in good terminal (even cursor hollow block drawing).

chrisduerr · 2019-06-03T19:57:17Z

Now that sounds extremely odd, I'll definitely have to take another look at the general structure of this PR then since I've got zero leads where this might be coming from. But thanks for testing and finding that!

nixpulvis · 2019-06-04T13:50:39Z

Getting this error when I close the running Alacritty window.

thread 'rendering' panicked at 'receive render update: RecvError', src/libcore/result.rs:997:5

chrisduerr · 2019-06-04T15:16:40Z

@nixpulvis Yeah that's currently 'intentional' since the rendering loop never shuts down. It just crashes when the main lib exits. It's a relatively simple fix but I just haven't gotten to it yet.

nixpulvis · 2019-06-04T15:31:34Z

@chrisduerr yea, I figured. Otherwise I'll be starting to run this branch (Linux/X11) for a while, and keep updated as you push.

commit b293d08 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 14:45:55 2019 -0700 Tidy up merge and ensure build behaves as expected commit 74c3432 Merge: 8e619b7 24651a6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 11:15:26 2019 -0700 Merge in config overhaul and from upstream commit 8e619b7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 10:55:24 2019 -0700 Format TextRun changes commit 24651a6 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Sun Oct 6 13:47:20 2019 +0300 Remove automatic config generation Fixes alacritty#2818. commit 729eef0 Author: Christian Duerr <contact@christianduerr.com> Date: Sat Oct 5 02:29:26 2019 +0200 Update to winit/glutin EventLoop 2.0 This takes the latest glutin master to port Alacritty to the EventLoop 2.0 rework. This changes a big part of the event loop handling by pushing the event loop in a separate thread from the renderer and running both in parallel. Fixes alacritty#2796. Fixes alacritty#2694. Fixes alacritty#2643. Fixes alacritty#2625. Fixes alacritty#2618. Fixes alacritty#2601. Fixes alacritty#2564. Fixes alacritty#2456. Fixes alacritty#2438. Fixes alacritty#2334. Fixes alacritty#2254. Fixes alacritty#2217. Fixes alacritty#1789. Fixes alacritty#1750. Fixes alacritty#1125. commit b0c6fdf Author: Clément L <porkepix@gmail.com> Date: Fri Oct 4 12:27:06 2019 +0200 Update VirtualKeyCode url in alacritty.yml commit cd515dc Merge: 816ec2f f6f444b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Oct 2 17:55:56 2019 -0700 Merge branch 'master' of https://github.com/jwilm/alacritty into font-ligatures commit 816ec2f Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Oct 2 17:50:43 2019 -0700 Create text_runs method on terminal to replace renderable_cells commit f6f444b Author: wayne <wayne.warren.s@gmail.com> Date: Wed Oct 2 13:49:19 2019 -0500 Add live config reload for font size commit 3e82aa2 Author: Paolo Capriotti <paolo@capriotti.io> Date: Sat Sep 28 18:59:27 2019 +0200 Concatenate parameters of title OSC A semicolon in a title OSC should be interpreted literally, not as a parameter separator, but the OSC parser is very simple and does not know about arities of commands. Therefore, this patch takes all the parameters returned by the OSC parser and reconstructs the original string by interspersing semicolons. Now an OSC like '\e]2;hello;world' will set the title to 'hello;world' and not 'hello' like before. commit fe6f176 Author: zsugabubus <zsugabubus@users.noreply.github.com> Date: Sat Sep 28 00:37:22 2019 +0000 Add `ReceiveChar` action for passing key's text commit 87cf14a Author: Christian Duerr <contact@christianduerr.com> Date: Thu Sep 26 20:55:30 2019 +0200 Fix selection not inverting terminal background Fixes a regression introduced in 9a0555b where the terminal background would not get inverted when selected. commit 9a0555b Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Thu Sep 26 17:10:54 2019 +0300 Fix cell opacity when color matches terminal bg Commit e964af8 introduced a regression, where if cell's bg color was equal to NamedColor::Background rgb color it was rendered with transparent background. However the correct behavior is to render bg transparent only when bg color is actually a NamedColor::Background. Fixes alacritty#2814. commit ad24485 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Thu Sep 26 15:44:59 2019 +0300 Fix overflow on wrong scroll region setting Fixes alacritty#2822. commit 7da599a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 18:58:51 2019 -0700 Clean up directwrite code and remove keytype_unwrap_char commit 0113097 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 18:39:26 2019 -0700 Fix call to from_iter_state that wasn't renamed. Avoid allocating Vec of RenderableCells, allocate a Vec of TextRun instead. commit f7d0b4a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:59:16 2019 -0700 Resolving review comments, mainly renaming commit 6f0454d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:46:17 2019 -0700 Update CHANGELOG and format recent changes. commit 91e0606 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:40:37 2019 -0700 Fix render_string to render as expected commit c1f0899 Author: mkosem <mattkosem@gmail.com> Date: Tue Sep 24 13:43:54 2019 -0400 Add Xembed support Fixes alacritty#631. commit 3980857 Merge: ab75676 856cddc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 23 11:05:18 2019 -0700 Pull master and merge commit 856cddc Author: Christian Duerr <contact@christianduerr.com> Date: Sat Sep 21 19:54:32 2019 +0200 Remove outdated TODO/FIXME comments commit ab75676 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 20:03:30 2019 -0700 Refactor iter_from_text_run to be from_text_run and move flag checking logic to text run draw loop in display commit 226e2d0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 19:41:28 2019 -0700 Update comment on KeyType commit fd1bcc3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 00:34:56 2019 -0700 Update Char for windows and mac osx commit 38d4eec Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:39:29 2019 -0700 Actually resolve merge conflict in CHANGELOG commit 717ca23 Merge: 5411fda ecfb55d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:39:04 2019 -0700 Resolve merge conflict in CHANGELOG commit 5411fda Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:38:00 2019 -0700 Update comment on HbFtExt. commit 282adae Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:31:57 2019 -0700 Rename KeyType Fallback to Char commit 37ff931 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:00:16 2019 -0700 Remove RenderLines in favor of converting TextRun directly RenderRect's. commit 1a4d7e0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 21:42:14 2019 -0700 Responding to review comments. Minor cleanups. commit adc929c Merge: 853619f 71a818c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 21:19:50 2019 -0700 Merge changes from upstream master. commit 71a818c Author: Christian Duerr <contact@christianduerr.com> Date: Thu Sep 19 23:15:06 2019 +0200 Initialize only visible characters This fixes an off-by-two error in the renderer which initializes characters 32 until 128 (inclusive) for each font whenever it is loaded. The ascii visible range however just goes from 32 until 126 (inclusive). commit ecfb55d Merge: 853619f 9a14ca4 Author: thunderseethe <emsmith1995@gmail.com> Date: Wed Sep 18 14:00:24 2019 -0700 Merge branch 'master' into font-ligatures commit 9a14ca4 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Wed Sep 18 22:21:01 2019 +0300 Rework default bindings This commit removes all bindings which are sending escapes from the default configuration file, adds bindings for F13-F24, adds bindings for ScrollToTop/ScrollToBottom actions, removes bindings for Super + F1-F12, fixes bindings for Alt + F1-F12. Fixes alacritty#2688. commit 52fecd7 Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 16 17:10:12 2019 +0200 Remove code for setting _NET_WM_PID This code is no longer necessary since winit now does this for us. commit c42df41 Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 16 17:02:29 2019 +0200 Fix bindings incorrectly getting replaced Fixes alacritty#2794. commit fb37a9c Author: Christian Duerr <contact@christianduerr.com> Date: Fri Sep 13 23:51:14 2019 +0000 Fix empty block selection detection Fixes alacritty#2789. commit 853619f Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 18:33:41 2019 -0700 Fix error returned for missing placeholder glyph. Refactor hidden_glyph_iter to be more flexible. commit ecec6ef Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 18:15:11 2019 -0700 Introduce placeholder keytype to represent a glyph that should render as nothing. commit 715263a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 15:27:30 2019 -0700 Refactor text_run for clarity of intent and clean up dead code. commit 54c33c7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 11:39:07 2019 -0700 Fix for windows and mac osx commit 2034c7b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 11:09:29 2019 -0700 Continue fixing up the codebase and making refactorings. Changes PLACEHOLDER_GLYPH to 0 (from 1). commit 1067fa6 Author: Matthias Krüger <matthias.krueger@famsik.de> Date: Tue Sep 10 18:08:01 2019 +0200 Replace uninitialized with MaybeUninit commit dd2f870 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 19:14:43 2019 -0700 Fix build errors on mac and windows. commit 8a36143 Merge: 79ef496 8aa406b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 18:37:58 2019 -0700 Pull master and resolve conflict in Cargo.lock commit 79ef496 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 18:34:24 2019 -0700 Resolving review comments, mainly minor cleanup and renamings. commit 8aa406b Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 9 21:40:48 2019 +0000 Bump minimum Rust version to 1.36.0 commit 86ffa18 Author: Nathan Lilienthal <nathan@nixpulvis.com> Date: Mon Sep 9 16:39:39 2019 -0400 Reset the Mouse Cursor While Selecting This change disabled the mouse cursor and URL highlight (underline) while a selection is in progress. A click to clear the selection doesn't trigger a URL action, but will re-enable the URL highlighting to indicate the next click will trigger the launcher. commit 20846ef Author: Bastien Orivel <eijebong@bananium.fr> Date: Fri Sep 6 21:35:28 2019 +0200 Update and dedupe parking_lot to 0.9 commit 168c0bf Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 4 18:46:05 2019 -0700 initial fix for selection issue, but it needs some cleaning up. current solution is hacky. commit 68ca294 Merge: 14b1b6c db63c31 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 4 17:48:06 2019 -0700 Merge branch 'master' of https://github.com/jwilm/alacritty into font-ligatures commit db63c31 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Tue Sep 3 18:42:24 2019 +0300 Fix Wayland selection clipboard not storing text when stopping outside of window commit 2f93fb3 Merge: b6c5f69 4ccda1a Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 19:21:25 2019 +0000 Fix legacy xparsecolor regression commit b6c5f69 Merge: 06e52a6 5f7fb4c Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 16:13:49 2019 +0000 Fix url highlight not showing with required modifiers commit 4ccda1a Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 02:35:34 2019 +0200 Fix legacy xparsecolor regression The legacy xparsecolor implementation assumed that the \007 ending would be passed to the parser, however it never is. This caused colors in the format #rrggbb to be interpreted as #rrggb, leading to incorrect colors showing up in Alacritty. Fixes alacritty#2759. commit 14b1b6c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 11:52:52 2019 -0700 Fix test code for macosx commit a8b8f4e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:53:27 2019 -0700 Replace use_thin_strokes method call with field access. commit af57cb9 Merge: aff6bfe 0ca96c3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:20:02 2019 -0700 Pull in updates from master and fix for windows. commit aff6bfe Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:19:05 2019 -0700 Resolve build errors on macos commit 0ca96c3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:51:59 2019 -0700 Resolve build error introduced by bold_italic merge. commit e012b4c Merge: 6c7b88e 06e52a6 Author: thunderseethe <emsmith1995@gmail.com> Date: Mon Aug 26 20:38:43 2019 -0700 Merge branch 'master' into font-ligatures commit 6c7b88e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:31:34 2019 -0700 Run cargo fmt over the changes. commit 9b3e7f9 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:26:46 2019 -0700 Fix windows build commit 5f7fb4c Author: Christian Duerr <contact@christianduerr.com> Date: Mon Aug 26 18:09:20 2019 +0200 Fix url highlight not showing with required modifiers commit 06e52a6 Merge: a7cf053 d86eff6 Author: Christian Duerr <contact@christianduerr.com> Date: Sun Aug 25 12:46:53 2019 +0000 Fix style issues in zsh completions commit a7cf053 Merge: ad03652 e69f259 Author: Christian Duerr <contact@christianduerr.com> Date: Sun Aug 25 12:35:19 2019 +0000 Add bold italic font support If the terminal escape sequences for bold and italic text are active, the text should be rendered as bold and italic. However, due to missing support in Alacritty, it would always render this text in bold. This adds support for combining the bold and italic escapes to render text in both styles and allows users to override the font for this scenario using the `font.bold_italic` configuration option. commit e69f259 Author: Chris Morgan <me@chrismorgan.info> Date: Sun Aug 25 20:46:52 2019 +1000 Add bold italic font support If the terminal escape sequences for bold and italic text are active, the text should be rendered as bold and italic. However, due to missing support in Alacritty, it would always render this text in bold. This adds support for combining the bold and italic escapes to render text in both styles and allows users to override the font for this scenario using the `font.bold_italic` configuration option. commit d86eff6 Author: Oliver Kiddle <okiddle@yahoo.co.uk> Date: Sun Aug 25 02:45:48 2019 +0200 Follow zsh conventions in zsh completion Declaring curcontext etc local is superfluous as _arguments states are not used. It is also superfluous to include an outer function definition syntax in zsh autoloadable functions. Zsh convention is not to capitalize descriptions. It is also better to use the imperative mood verb form for descriptions as this allows them to start with the shortest form of the verb - e.g. "reduce" instead of "reduces" and results in better grammar in the absence of a sentence subject. I'd recommend this in the --help output too. Using _guard for the position and dimensions was unnecessary given that the values are not mixed with other matches. commit ad03652 Author: John Sullivan <jsullivan@csumb.edu> Date: Sat Aug 24 16:18:51 2019 -0700 Show text cursor when pressing shift in mouse mode Fixes alacritty#2550. commit 601724e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 18 11:19:17 2019 -0700 Fix typo bee -> be commit bb57c4a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 18 11:17:29 2019 -0700 Fix for compilation on windows and mac osx commit 70edadd Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 11:16:19 2019 -0700 Fix typos in documentation, remove custom Debug impls for TextRun commit 9a75eda Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:56:01 2019 -0700 Remove changes to ansi.rs after file was updated to comply with clippy. commit 438c4e7 Merge: a181714 d9d6986 Author: thunderseethe <emsmith1995@gmail.com> Date: Sat Aug 17 10:53:35 2019 -0700 Merge branch 'master' into font-ligatures commit a181714 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:50:55 2019 -0700 Move code for hidden glyphs outside of render_text_run and format code. commit 1708927 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:43:46 2019 -0700 Fix rendering of hidden text based on broken.txt commit 3677669 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 15:14:33 2019 -0700 Need to rework handling of hidden text. commit cd5201e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 15:06:11 2019 -0700 Don't update strikethrough and underline for hidden runs. commit 549acfc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:27:17 2019 -0700 Change cell_iter() -> cells() at unchanged callsites. commit c7c6341 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:23:10 2019 -0700 Run fmt over refactored code. commit 922cd41 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:22:26 2019 -0700 Resolving review comments in text_run and ft commit e423a08 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 13:19:07 2019 -0700 Reduce scope of hb-ft feature, replace with linux toggled cfg commit 499fe03 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Aug 9 16:00:30 2019 -0700 Cargo fmt code, fix residual clippy errors in ansi.rs commit 3f1f25d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 18:04:13 2019 -0700 Remove "hb-ft" from default feature list. commit e392c88 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 18:02:56 2019 -0700 Fix clippy errors. Remove extraneous parameters from lines.update() for TextRun. commit d04e706 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:45:58 2019 -0700 Merge in latest changes to rects (now lines). commit 73e8a88 Merge: ef3a5a9 677a439 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:37:55 2019 -0700 Resolve merge conflict in rects.rs commit 677a439 Merge: cc34439 33cfc52 Author: thunderseethe <emsmith1995@gmail.com> Date: Tue Aug 6 17:33:48 2019 -0700 Merge branch 'master' into font-ligatures commit ef3a5a9 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:32:49 2019 -0700 Ran formatter over new changes in code. Added line to CHANGELOG.md commit 3ceaf9c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:28:39 2019 -0700 Moved text_run mod to it's own folder, fixed update_lines_text_run() method, added utility methods to TextRun struct. Added some docs and formatted changed files. commit cc34439 Merge: d6287c3 14fa026 Author: thunderseethe <emsmith1995@gmail.com> Date: Mon Aug 5 16:09:21 2019 -0700 Merge branch 'master' into font-ligatures commit d6287c3 Merge: d2076ae 9dddf64 Author: thunderseethe <emsmith1995@gmail.com> Date: Thu Aug 1 10:30:31 2019 -0700 Merge branch 'master' into font-ligatures commit d2076ae Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 31 16:06:25 2019 -0700 Add use_font_ligatures conifg option, toggles clig and liga harfbuzz features commit 2935bf4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Jul 28 14:18:13 2019 -0700 Resolve clippy error, remove hb-ft feature from default list to hopefully fix builds on macosx/windwos commit 70024db Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 19:14:58 2019 -0700 Wide characters now render properly. Last item is to look at cleaning up fallback character code post-shaping. commit 5f53cc4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 19:04:16 2019 -0700 Resolved issue with cursor not rendering, need to load an explicit glyph index. Loading a char now unconditionally hits fallback logic which won't do what's needed to set metrics for our font. commit 6447ef8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 18:29:50 2019 -0700 Able to fallback to loading a font if shaping fails to find a glyph. However cursor rendering is now broken and WIDE_CHAR's are not rendered correctly. commit 84c62e7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 17:00:28 2019 -0700 Resolve bug with strikethrough and underlining. Add logic in TextRunIter to account for WIDE_CHAR when building run. commit 244a3a6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:05:42 2019 -0700 Remove hb-ft from default feature list in alacritty_terminal commit b3b8a40 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:01:28 2019 -0700 Update Cargo.lock to 0.2.60 inline with main repo lock file commit d970528 Merge: f1b5388 54c3c97 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:00:06 2019 -0700 Merge branch 'font-ligatures' of https://github.com/thunderseethe/alacritty into font-ligatures commit f1b5388 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 18:57:35 2019 -0700 Fix build error in cursor.rs when hb-ft feautre is off commit 54c3c97 Merge: 4bfedf0 44c1e90 Author: thunderseethe <emsmith1995@gmail.com> Date: Thu Jul 25 18:54:50 2019 -0700 Merge branch 'master' into font-ligatures commit 4bfedf0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 18:20:03 2019 -0700 Further clean up to reduce code in PR. commit de83c0b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:39:31 2019 -0700 Added documentation to the text_run module. commit a32a835 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:21:45 2019 -0700 Removed HbError and related code. Fixed errors were chars were being used as glyph keys with hb-ft on. Clean up more extraneous changes. commit d3513f3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:00:55 2019 -0700 Continuing clean up of PR. commit cf777a1 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 16:43:52 2019 -0700 Clean up superfluous changes from rustfmt that clutter PR. commit dd69ce6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 10:22:43 2019 -0700 Fix build with hb-ft feature turned off. commit 7c3896b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 24 15:47:19 2019 -0700 Clean up some of the code that is no longer needed and swap GlyphKey for indice. commit 09755da Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 24 10:51:24 2019 -0700 Clean up warning and remove some code that is no longer used. commit 88f334d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:43:26 2019 -0700 Replace render_string's calls to render_cell with call to render_text_run when hb-ft is on. commit 09a6f9b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:32:38 2019 -0700 Store string of rendered chars and zero width chars in text run. commit dea2a41 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:06:59 2019 -0700 Remove cloning of rc.inner by introducing RunStart struct that hold minimal state needed. commit 03daff8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 17:16:37 2019 -0700 Cleaned up opt_pair impl commit a54de7b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 17 16:54:22 2019 -0700 cache now exposes shape method that calls underlying rasterizer shape method. Still not ideal as better use can probably be made of glyph_positions returned by harfbuzz but it will be involved to work those down to the Batch that renders cells at gl float values. commit 87df12b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 12 19:13:44 2019 -0700 Create render_text_run function on Renderer, this pushes call to hb shape one level deeper. Aim to move call into glyph_cache and expose through some API. commit a3f8d65 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 12 18:13:52 2019 -0700 Created new TextRun struct to represent the idea of a run of text that all share the same renderablecell except for (column, chars) commit 146f824 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 10 16:03:29 2019 -0700 Replace sequence of maps with an iterator that produces text runs. commit a4084bc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 9 15:57:08 2019 -0700 Place holder commit to check something in master. Just more debugging statements. commit e1e33c8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 9 15:48:28 2019 -0700 Looking into why whitespace is rendering is incorrectly commit 662fbe5 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Jul 8 17:40:33 2019 -0700 Switch to harfbuzz_rs and change GlyphKey to use a char or glyph_index commit 79facbc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 18:42:56 2019 -0700 Tried setting scale and ppem but it didn't change anything. commit 5df92b4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 11:30:46 2019 -0700 whitespace funky. commit f28f6fe Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 11:23:10 2019 -0700 Rendering is normal but font ligatures still don't work commit a2ab0cc Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Sat Mar 30 18:39:34 2019 -0700 Break everything commit 1218fab Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Sat Mar 16 10:37:50 2019 -0700 Fix clippy errors commit bc7d5e4 Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Fri Mar 15 20:30:27 2019 -0700 Refine harfbuzz shaping more, now vaguely resembles the real text. commit ab620c9 Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Fri Mar 15 18:32:43 2019 -0700 Fix cargo.lock CI and everything should now work. commit 2d59156 Author: hack <anirudhqazxswced+gitlab@gmail.com> Date: Fri Mar 15 18:14:53 2019 -0700 Add harfbuzz-freetype support Doesn't render properly yet, though.

This takes the latest glutin master to port Alacritty to the EventLoop 2.0 rework. This changes a big part of the event loop handling by pushing the event loop in a separate thread from the renderer and running both in parallel. Fixes alacritty#2796. Fixes alacritty#2694. Fixes alacritty#2643. Fixes alacritty#2625. Fixes alacritty#2618. Fixes alacritty#2601. Fixes alacritty#2564. Fixes alacritty#2456. Fixes alacritty#2438. Fixes alacritty#2334. Fixes alacritty#2254. Fixes alacritty#2217. Fixes alacritty#1789. Fixes alacritty#1750. Fixes alacritty#1125.

commit b293d08 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 14:45:55 2019 -0700 Tidy up merge and ensure build behaves as expected commit 74c3432 Merge: 8e619b7 24651a6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 11:15:26 2019 -0700 Merge in config overhaul and from upstream commit 8e619b7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Oct 7 10:55:24 2019 -0700 Format TextRun changes commit 24651a6 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Sun Oct 6 13:47:20 2019 +0300 Remove automatic config generation Fixes alacritty#2818. commit 729eef0 Author: Christian Duerr <contact@christianduerr.com> Date: Sat Oct 5 02:29:26 2019 +0200 Update to winit/glutin EventLoop 2.0 This takes the latest glutin master to port Alacritty to the EventLoop 2.0 rework. This changes a big part of the event loop handling by pushing the event loop in a separate thread from the renderer and running both in parallel. Fixes alacritty#2796. Fixes alacritty#2694. Fixes alacritty#2643. Fixes alacritty#2625. Fixes alacritty#2618. Fixes alacritty#2601. Fixes alacritty#2564. Fixes alacritty#2456. Fixes alacritty#2438. Fixes alacritty#2334. Fixes alacritty#2254. Fixes alacritty#2217. Fixes alacritty#1789. Fixes alacritty#1750. Fixes alacritty#1125. commit b0c6fdf Author: Clément L <porkepix@gmail.com> Date: Fri Oct 4 12:27:06 2019 +0200 Update VirtualKeyCode url in alacritty.yml commit cd515dc Merge: 816ec2f f6f444b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Oct 2 17:55:56 2019 -0700 Merge branch 'master' of https://github.com/jwilm/alacritty into font-ligatures commit 816ec2f Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Oct 2 17:50:43 2019 -0700 Create text_runs method on terminal to replace renderable_cells commit f6f444b Author: wayne <wayne.warren.s@gmail.com> Date: Wed Oct 2 13:49:19 2019 -0500 Add live config reload for font size commit 3e82aa2 Author: Paolo Capriotti <paolo@capriotti.io> Date: Sat Sep 28 18:59:27 2019 +0200 Concatenate parameters of title OSC A semicolon in a title OSC should be interpreted literally, not as a parameter separator, but the OSC parser is very simple and does not know about arities of commands. Therefore, this patch takes all the parameters returned by the OSC parser and reconstructs the original string by interspersing semicolons. Now an OSC like '\e]2;hello;world' will set the title to 'hello;world' and not 'hello' like before. commit fe6f176 Author: zsugabubus <zsugabubus@users.noreply.github.com> Date: Sat Sep 28 00:37:22 2019 +0000 Add `ReceiveChar` action for passing key's text commit 87cf14a Author: Christian Duerr <contact@christianduerr.com> Date: Thu Sep 26 20:55:30 2019 +0200 Fix selection not inverting terminal background Fixes a regression introduced in 9a0555b where the terminal background would not get inverted when selected. commit 9a0555b Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Thu Sep 26 17:10:54 2019 +0300 Fix cell opacity when color matches terminal bg Commit e964af8 introduced a regression, where if cell's bg color was equal to NamedColor::Background rgb color it was rendered with transparent background. However the correct behavior is to render bg transparent only when bg color is actually a NamedColor::Background. Fixes alacritty#2814. commit ad24485 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Thu Sep 26 15:44:59 2019 +0300 Fix overflow on wrong scroll region setting Fixes alacritty#2822. commit 7da599a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 18:58:51 2019 -0700 Clean up directwrite code and remove keytype_unwrap_char commit 0113097 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 18:39:26 2019 -0700 Fix call to from_iter_state that wasn't renamed. Avoid allocating Vec of RenderableCells, allocate a Vec of TextRun instead. commit f7d0b4a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:59:16 2019 -0700 Resolving review comments, mainly renaming commit 6f0454d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:46:17 2019 -0700 Update CHANGELOG and format recent changes. commit 91e0606 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 25 17:40:37 2019 -0700 Fix render_string to render as expected commit c1f0899 Author: mkosem <mattkosem@gmail.com> Date: Tue Sep 24 13:43:54 2019 -0400 Add Xembed support Fixes alacritty#631. commit 3980857 Merge: ab75676 856cddc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 23 11:05:18 2019 -0700 Pull master and merge commit 856cddc Author: Christian Duerr <contact@christianduerr.com> Date: Sat Sep 21 19:54:32 2019 +0200 Remove outdated TODO/FIXME comments commit ab75676 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 20:03:30 2019 -0700 Refactor iter_from_text_run to be from_text_run and move flag checking logic to text run draw loop in display commit 226e2d0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 19:41:28 2019 -0700 Update comment on KeyType commit fd1bcc3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Sep 20 00:34:56 2019 -0700 Update Char for windows and mac osx commit 38d4eec Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:39:29 2019 -0700 Actually resolve merge conflict in CHANGELOG commit 717ca23 Merge: 5411fda ecfb55d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:39:04 2019 -0700 Resolve merge conflict in CHANGELOG commit 5411fda Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:38:00 2019 -0700 Update comment on HbFtExt. commit 282adae Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:31:57 2019 -0700 Rename KeyType Fallback to Char commit 37ff931 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 23:00:16 2019 -0700 Remove RenderLines in favor of converting TextRun directly RenderRect's. commit 1a4d7e0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 21:42:14 2019 -0700 Responding to review comments. Minor cleanups. commit adc929c Merge: 853619f 71a818c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Sep 19 21:19:50 2019 -0700 Merge changes from upstream master. commit 71a818c Author: Christian Duerr <contact@christianduerr.com> Date: Thu Sep 19 23:15:06 2019 +0200 Initialize only visible characters This fixes an off-by-two error in the renderer which initializes characters 32 until 128 (inclusive) for each font whenever it is loaded. The ascii visible range however just goes from 32 until 126 (inclusive). commit ecfb55d Merge: 853619f 9a14ca4 Author: thunderseethe <emsmith1995@gmail.com> Date: Wed Sep 18 14:00:24 2019 -0700 Merge branch 'master' into font-ligatures commit 9a14ca4 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Wed Sep 18 22:21:01 2019 +0300 Rework default bindings This commit removes all bindings which are sending escapes from the default configuration file, adds bindings for F13-F24, adds bindings for ScrollToTop/ScrollToBottom actions, removes bindings for Super + F1-F12, fixes bindings for Alt + F1-F12. Fixes alacritty#2688. commit 52fecd7 Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 16 17:10:12 2019 +0200 Remove code for setting _NET_WM_PID This code is no longer necessary since winit now does this for us. commit c42df41 Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 16 17:02:29 2019 +0200 Fix bindings incorrectly getting replaced Fixes alacritty#2794. commit fb37a9c Author: Christian Duerr <contact@christianduerr.com> Date: Fri Sep 13 23:51:14 2019 +0000 Fix empty block selection detection Fixes alacritty#2789. commit 853619f Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 18:33:41 2019 -0700 Fix error returned for missing placeholder glyph. Refactor hidden_glyph_iter to be more flexible. commit ecec6ef Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 18:15:11 2019 -0700 Introduce placeholder keytype to represent a glyph that should render as nothing. commit 715263a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 15:27:30 2019 -0700 Refactor text_run for clarity of intent and clean up dead code. commit 54c33c7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 11:39:07 2019 -0700 Fix for windows and mac osx commit 2034c7b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Sep 10 11:09:29 2019 -0700 Continue fixing up the codebase and making refactorings. Changes PLACEHOLDER_GLYPH to 0 (from 1). commit 1067fa6 Author: Matthias Krüger <matthias.krueger@famsik.de> Date: Tue Sep 10 18:08:01 2019 +0200 Replace uninitialized with MaybeUninit commit dd2f870 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 19:14:43 2019 -0700 Fix build errors on mac and windows. commit 8a36143 Merge: 79ef496 8aa406b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 18:37:58 2019 -0700 Pull master and resolve conflict in Cargo.lock commit 79ef496 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Sep 9 18:34:24 2019 -0700 Resolving review comments, mainly minor cleanup and renamings. commit 8aa406b Author: Christian Duerr <contact@christianduerr.com> Date: Mon Sep 9 21:40:48 2019 +0000 Bump minimum Rust version to 1.36.0 commit 86ffa18 Author: Nathan Lilienthal <nathan@nixpulvis.com> Date: Mon Sep 9 16:39:39 2019 -0400 Reset the Mouse Cursor While Selecting This change disabled the mouse cursor and URL highlight (underline) while a selection is in progress. A click to clear the selection doesn't trigger a URL action, but will re-enable the URL highlighting to indicate the next click will trigger the launcher. commit 20846ef Author: Bastien Orivel <eijebong@bananium.fr> Date: Fri Sep 6 21:35:28 2019 +0200 Update and dedupe parking_lot to 0.9 commit 168c0bf Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 4 18:46:05 2019 -0700 initial fix for selection issue, but it needs some cleaning up. current solution is hacky. commit 68ca294 Merge: 14b1b6c db63c31 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Sep 4 17:48:06 2019 -0700 Merge branch 'master' of https://github.com/jwilm/alacritty into font-ligatures commit db63c31 Author: Kirill Chibisov <wchibisovkirill@gmail.com> Date: Tue Sep 3 18:42:24 2019 +0300 Fix Wayland selection clipboard not storing text when stopping outside of window commit 2f93fb3 Merge: b6c5f69 4ccda1a Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 19:21:25 2019 +0000 Fix legacy xparsecolor regression commit b6c5f69 Merge: 06e52a6 5f7fb4c Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 16:13:49 2019 +0000 Fix url highlight not showing with required modifiers commit 4ccda1a Author: Christian Duerr <contact@christianduerr.com> Date: Wed Aug 28 02:35:34 2019 +0200 Fix legacy xparsecolor regression The legacy xparsecolor implementation assumed that the \007 ending would be passed to the parser, however it never is. This caused colors in the format #rrggbb to be interpreted as #rrggb, leading to incorrect colors showing up in Alacritty. Fixes alacritty#2759. commit 14b1b6c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 11:52:52 2019 -0700 Fix test code for macosx commit a8b8f4e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:53:27 2019 -0700 Replace use_thin_strokes method call with field access. commit af57cb9 Merge: aff6bfe 0ca96c3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:20:02 2019 -0700 Pull in updates from master and fix for windows. commit aff6bfe Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 27 10:19:05 2019 -0700 Resolve build errors on macos commit 0ca96c3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:51:59 2019 -0700 Resolve build error introduced by bold_italic merge. commit e012b4c Merge: 6c7b88e 06e52a6 Author: thunderseethe <emsmith1995@gmail.com> Date: Mon Aug 26 20:38:43 2019 -0700 Merge branch 'master' into font-ligatures commit 6c7b88e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:31:34 2019 -0700 Run cargo fmt over the changes. commit 9b3e7f9 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Aug 26 20:26:46 2019 -0700 Fix windows build commit 5f7fb4c Author: Christian Duerr <contact@christianduerr.com> Date: Mon Aug 26 18:09:20 2019 +0200 Fix url highlight not showing with required modifiers commit 06e52a6 Merge: a7cf053 d86eff6 Author: Christian Duerr <contact@christianduerr.com> Date: Sun Aug 25 12:46:53 2019 +0000 Fix style issues in zsh completions commit a7cf053 Merge: ad03652 e69f259 Author: Christian Duerr <contact@christianduerr.com> Date: Sun Aug 25 12:35:19 2019 +0000 Add bold italic font support If the terminal escape sequences for bold and italic text are active, the text should be rendered as bold and italic. However, due to missing support in Alacritty, it would always render this text in bold. This adds support for combining the bold and italic escapes to render text in both styles and allows users to override the font for this scenario using the `font.bold_italic` configuration option. commit e69f259 Author: Chris Morgan <me@chrismorgan.info> Date: Sun Aug 25 20:46:52 2019 +1000 Add bold italic font support If the terminal escape sequences for bold and italic text are active, the text should be rendered as bold and italic. However, due to missing support in Alacritty, it would always render this text in bold. This adds support for combining the bold and italic escapes to render text in both styles and allows users to override the font for this scenario using the `font.bold_italic` configuration option. commit d86eff6 Author: Oliver Kiddle <okiddle@yahoo.co.uk> Date: Sun Aug 25 02:45:48 2019 +0200 Follow zsh conventions in zsh completion Declaring curcontext etc local is superfluous as _arguments states are not used. It is also superfluous to include an outer function definition syntax in zsh autoloadable functions. Zsh convention is not to capitalize descriptions. It is also better to use the imperative mood verb form for descriptions as this allows them to start with the shortest form of the verb - e.g. "reduce" instead of "reduces" and results in better grammar in the absence of a sentence subject. I'd recommend this in the --help output too. Using _guard for the position and dimensions was unnecessary given that the values are not mixed with other matches. commit ad03652 Author: John Sullivan <jsullivan@csumb.edu> Date: Sat Aug 24 16:18:51 2019 -0700 Show text cursor when pressing shift in mouse mode Fixes alacritty#2550. commit 601724e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 18 11:19:17 2019 -0700 Fix typo bee -> be commit bb57c4a Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 18 11:17:29 2019 -0700 Fix for compilation on windows and mac osx commit 70edadd Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 11:16:19 2019 -0700 Fix typos in documentation, remove custom Debug impls for TextRun commit 9a75eda Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:56:01 2019 -0700 Remove changes to ansi.rs after file was updated to comply with clippy. commit 438c4e7 Merge: a181714 d9d6986 Author: thunderseethe <emsmith1995@gmail.com> Date: Sat Aug 17 10:53:35 2019 -0700 Merge branch 'master' into font-ligatures commit a181714 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:50:55 2019 -0700 Move code for hidden glyphs outside of render_text_run and format code. commit 1708927 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sat Aug 17 10:43:46 2019 -0700 Fix rendering of hidden text based on broken.txt commit 3677669 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 15:14:33 2019 -0700 Need to rework handling of hidden text. commit cd5201e Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 15:06:11 2019 -0700 Don't update strikethrough and underline for hidden runs. commit 549acfc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:27:17 2019 -0700 Change cell_iter() -> cells() at unchanged callsites. commit c7c6341 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:23:10 2019 -0700 Run fmt over refactored code. commit 922cd41 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 14:22:26 2019 -0700 Resolving review comments in text_run and ft commit e423a08 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Aug 11 13:19:07 2019 -0700 Reduce scope of hb-ft feature, replace with linux toggled cfg commit 499fe03 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Aug 9 16:00:30 2019 -0700 Cargo fmt code, fix residual clippy errors in ansi.rs commit 3f1f25d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 18:04:13 2019 -0700 Remove "hb-ft" from default feature list. commit e392c88 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 18:02:56 2019 -0700 Fix clippy errors. Remove extraneous parameters from lines.update() for TextRun. commit d04e706 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:45:58 2019 -0700 Merge in latest changes to rects (now lines). commit 73e8a88 Merge: ef3a5a9 677a439 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:37:55 2019 -0700 Resolve merge conflict in rects.rs commit 677a439 Merge: cc34439 33cfc52 Author: thunderseethe <emsmith1995@gmail.com> Date: Tue Aug 6 17:33:48 2019 -0700 Merge branch 'master' into font-ligatures commit ef3a5a9 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:32:49 2019 -0700 Ran formatter over new changes in code. Added line to CHANGELOG.md commit 3ceaf9c Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Aug 6 17:28:39 2019 -0700 Moved text_run mod to it's own folder, fixed update_lines_text_run() method, added utility methods to TextRun struct. Added some docs and formatted changed files. commit cc34439 Merge: d6287c3 14fa026 Author: thunderseethe <emsmith1995@gmail.com> Date: Mon Aug 5 16:09:21 2019 -0700 Merge branch 'master' into font-ligatures commit d6287c3 Merge: d2076ae 9dddf64 Author: thunderseethe <emsmith1995@gmail.com> Date: Thu Aug 1 10:30:31 2019 -0700 Merge branch 'master' into font-ligatures commit d2076ae Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 31 16:06:25 2019 -0700 Add use_font_ligatures conifg option, toggles clig and liga harfbuzz features commit 2935bf4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Sun Jul 28 14:18:13 2019 -0700 Resolve clippy error, remove hb-ft feature from default list to hopefully fix builds on macosx/windwos commit 70024db Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 19:14:58 2019 -0700 Wide characters now render properly. Last item is to look at cleaning up fallback character code post-shaping. commit 5f53cc4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 19:04:16 2019 -0700 Resolved issue with cursor not rendering, need to load an explicit glyph index. Loading a char now unconditionally hits fallback logic which won't do what's needed to set metrics for our font. commit 6447ef8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 18:29:50 2019 -0700 Able to fallback to loading a font if shaping fails to find a glyph. However cursor rendering is now broken and WIDE_CHAR's are not rendered correctly. commit 84c62e7 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 26 17:00:28 2019 -0700 Resolve bug with strikethrough and underlining. Add logic in TextRunIter to account for WIDE_CHAR when building run. commit 244a3a6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:05:42 2019 -0700 Remove hb-ft from default feature list in alacritty_terminal commit b3b8a40 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:01:28 2019 -0700 Update Cargo.lock to 0.2.60 inline with main repo lock file commit d970528 Merge: f1b5388 54c3c97 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 19:00:06 2019 -0700 Merge branch 'font-ligatures' of https://github.com/thunderseethe/alacritty into font-ligatures commit f1b5388 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 18:57:35 2019 -0700 Fix build error in cursor.rs when hb-ft feautre is off commit 54c3c97 Merge: 4bfedf0 44c1e90 Author: thunderseethe <emsmith1995@gmail.com> Date: Thu Jul 25 18:54:50 2019 -0700 Merge branch 'master' into font-ligatures commit 4bfedf0 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 18:20:03 2019 -0700 Further clean up to reduce code in PR. commit de83c0b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:39:31 2019 -0700 Added documentation to the text_run module. commit a32a835 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:21:45 2019 -0700 Removed HbError and related code. Fixed errors were chars were being used as glyph keys with hb-ft on. Clean up more extraneous changes. commit d3513f3 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 17:00:55 2019 -0700 Continuing clean up of PR. commit cf777a1 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 16:43:52 2019 -0700 Clean up superfluous changes from rustfmt that clutter PR. commit dd69ce6 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Thu Jul 25 10:22:43 2019 -0700 Fix build with hb-ft feature turned off. commit 7c3896b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 24 15:47:19 2019 -0700 Clean up some of the code that is no longer needed and swap GlyphKey for indice. commit 09755da Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 24 10:51:24 2019 -0700 Clean up warning and remove some code that is no longer used. commit 88f334d Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:43:26 2019 -0700 Replace render_string's calls to render_cell with call to render_text_run when hb-ft is on. commit 09a6f9b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:32:38 2019 -0700 Store string of rendered chars and zero width chars in text run. commit dea2a41 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 18:06:59 2019 -0700 Remove cloning of rc.inner by introducing RunStart struct that hold minimal state needed. commit 03daff8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 23 17:16:37 2019 -0700 Cleaned up opt_pair impl commit a54de7b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 17 16:54:22 2019 -0700 cache now exposes shape method that calls underlying rasterizer shape method. Still not ideal as better use can probably be made of glyph_positions returned by harfbuzz but it will be involved to work those down to the Batch that renders cells at gl float values. commit 87df12b Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 12 19:13:44 2019 -0700 Create render_text_run function on Renderer, this pushes call to hb shape one level deeper. Aim to move call into glyph_cache and expose through some API. commit a3f8d65 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Fri Jul 12 18:13:52 2019 -0700 Created new TextRun struct to represent the idea of a run of text that all share the same renderablecell except for (column, chars) commit 146f824 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 10 16:03:29 2019 -0700 Replace sequence of maps with an iterator that produces text runs. commit a4084bc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 9 15:57:08 2019 -0700 Place holder commit to check something in master. Just more debugging statements. commit e1e33c8 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Tue Jul 9 15:48:28 2019 -0700 Looking into why whitespace is rendering is incorrectly commit 662fbe5 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Mon Jul 8 17:40:33 2019 -0700 Switch to harfbuzz_rs and change GlyphKey to use a char or glyph_index commit 79facbc Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 18:42:56 2019 -0700 Tried setting scale and ppem but it didn't change anything. commit 5df92b4 Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 11:30:46 2019 -0700 whitespace funky. commit f28f6fe Author: thunderseethe <thunderseethe.dev@gmail.com> Date: Wed Jul 3 11:23:10 2019 -0700 Rendering is normal but font ligatures still don't work commit a2ab0cc Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Sat Mar 30 18:39:34 2019 -0700 Break everything commit 1218fab Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Sat Mar 16 10:37:50 2019 -0700 Fix clippy errors commit bc7d5e4 Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Fri Mar 15 20:30:27 2019 -0700 Refine harfbuzz shaping more, now vaguely resembles the real text. commit ab620c9 Author: Anirudh Balaji <anirudhqazxswced@gmail.com> Date: Fri Mar 15 18:32:43 2019 -0700 Fix cargo.lock CI and everything should now work. commit 2d59156 Author: hack <anirudhqazxswced+gitlab@gmail.com> Date: Fri Mar 15 18:14:53 2019 -0700 Add harfbuzz-freetype support Doesn't render properly yet, though.

chrisduerr mentioned this pull request May 13, 2019

EventLoop 2.0 swallowing events rust-windowing/winit#865

Closed

chrisduerr added this to the Version 0.3.3 milestone May 14, 2019

chrisduerr added the C - awaiting progress label May 18, 2019

nixpulvis reviewed Jun 1, 2019

View reviewed changes

nixpulvis removed this from the Version 0.3.3 milestone Jun 1, 2019

chrisduerr mentioned this pull request Jun 2, 2019

Use dynamically sized buffer for OSC alacritty/vte#20

Closed

chrisduerr added this to the Version 0.3.4 milestone Jun 3, 2019

chrisduerr force-pushed the evlp2 branch from 94a091f to 5d0df71 Compare June 3, 2019 19:59

chrisduerr mentioned this pull request Jun 4, 2019

Insert cursor disappearing in Neovim #2355

Closed

chrisduerr added 10 commits October 4, 2019 23:13

Fix style issues

aaf1d77

Remove unnecessary return type enum

1d3fab8

Update dependencies

7d65bb5

Fix resetting font size on config reload

838443e

Fix message bar not cleared on config reload

6b57afe

Add change log entries for Wayland cursor fixes

333b40d

Fix simple fullscreen

68a41cc

Move font resize logic to display.rs

e1d2d53

Add change log entry for Windows fixes

76accb5

Fix macOS compilation warnings

57414a8

chrisduerr force-pushed the evlp2 branch from ee480f3 to 57414a8 Compare October 4, 2019 21:16

chrisduerr requested a review from nixpulvis October 4, 2019 21:16

Format code

549a482

kchibisov mentioned this pull request Oct 5, 2019

alacritty doesn't close unless it is visible on sway #2851

Closed

chrisduerr merged commit 729eef0 into alacritty:master Oct 5, 2019

andersevenrud mentioned this pull request Oct 5, 2019

Redraw randomly hangs until a keypress #824

Closed

laanwj mentioned this pull request Oct 5, 2019

Lagging while using nano, vim, etc. #2217

Closed

nixpulvis mentioned this pull request Oct 7, 2019

Alacritty not updating when no input is happening #2345

Closed

dvergeylen mentioned this pull request Oct 8, 2019

Typing at sign (@) and pipe (|) doesn’t work properly #1349

Closed

chrisduerr mentioned this pull request Oct 17, 2019

Extract into library/widget #450

Closed

juchiast mentioned this pull request Oct 23, 2019

Modifier state is wrongly set while switching between windows #2906

Closed

kchibisov mentioned this pull request Oct 28, 2019

Message bar is overlapping terminal content #2924

Closed

iceiix mentioned this pull request Jan 5, 2020

Update to glutin =0.22.0-alpha5, remove wasm_stub iceiix/stevenarella#260

Merged

p5a0u9l mentioned this pull request Nov 25, 2020

Windows Full screen + Alt-tab not working? #4485

Closed

Conversation

chrisduerr commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Osspial commented May 14, 2019

Uh oh!

cole-h commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisduerr commented May 14, 2019

Uh oh!

chrisduerr commented May 14, 2019

Uh oh!

Osspial commented May 16, 2019

Uh oh!

chrisduerr commented May 16, 2019

Uh oh!

Osspial commented May 18, 2019

Uh oh!

chrisduerr commented May 18, 2019

Uh oh!

da-x commented May 26, 2019

Uh oh!

chrisduerr commented May 26, 2019

Uh oh!

Osspial commented May 28, 2019

Uh oh!

nixpulvis Jun 1, 2019

Choose a reason for hiding this comment

Uh oh!

kchibisov commented Jun 3, 2019

Uh oh!

chrisduerr commented Jun 3, 2019

Uh oh!

kchibisov commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisduerr commented Jun 3, 2019

Uh oh!

kchibisov commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kchibisov commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisduerr commented Jun 3, 2019

Uh oh!

nixpulvis commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisduerr commented Jun 4, 2019

Uh oh!

nixpulvis commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

18 participants

chrisduerr commented May 13, 2019 •

edited

Loading

cole-h commented May 14, 2019 •

edited

Loading

kchibisov commented Jun 3, 2019 •

edited

Loading

kchibisov commented Jun 3, 2019 •

edited

Loading

kchibisov commented Jun 3, 2019 •

edited

Loading

nixpulvis commented Jun 4, 2019 •

edited

Loading

nixpulvis commented Jun 4, 2019 •

edited

Loading