feat: dockerfile for building migration runner image#9417
Merged
Gnanasundari24 merged 9 commits intomainfrom Oct 1, 2025
Merged
feat: dockerfile for building migration runner image#9417Gnanasundari24 merged 9 commits intomainfrom
Gnanasundari24 merged 9 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
pixincreate
previously approved these changes
Sep 22, 2025
Contributor
Author
|
shouldn't we include the migration files in the router docker image itself and run the migration when the docker image is initialized? |
Member
Nope, I would not prefer doing this, to prevent destructive queries from being run automatically. |
SanchithHegde
approved these changes
Sep 26, 2025
pixincreate
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adding a new
dockerfilefor building ahyperswitch-migration-runnerimage.This dockerfile,
docker/migration-runner.Dockerfile, contains the respective router version's:along with diesel cli installed. This helps us run db migrations inside
air-gappedclusters without the need to pull the migration files from github.Additional Changes
Motivation and Context
When deploying hyperswitch helm charts in Kubernetes cluster, we use a init pod to pull the migration files from the github and run db migrations. But in case of an air-gapped cluster, which doesn't have access to internet, this process is not feasible.
Building and releasing the migration-runner image for each stable release along with the other standalone builds will solve this issue.
How did you test it?
pgurl, and migrations ran successfully:Checklist
cargo +nightly fmt --allcargo clippy