feat(connector): [Paysafe] implement Skrill, interac and paysafecard Payment Method#9396
Merged
Gnanasundari24 merged 9 commits intomainfrom Sep 18, 2025
Merged
feat(connector): [Paysafe] implement Skrill, interac and paysafecard Payment Method#9396Gnanasundari24 merged 9 commits intomainfrom
Gnanasundari24 merged 9 commits intomainfrom
Conversation
Changed Files
|
Sakilmostak
previously approved these changes
Sep 16, 2025
Comment on lines
+574
to
+586
| let card = PaysafeCard { | ||
| card_num: req_card.card_number.clone(), | ||
| card_expiry: PaysafeCardExpiry { | ||
| month: req_card.card_exp_month.clone(), | ||
| year: req_card.get_expiry_year_4_digit(), | ||
| }, | ||
| cvv: if req_card.card_cvc.clone().expose().is_empty() { | ||
| None | ||
| } else { | ||
| Some(req_card.card_cvc.clone()) | ||
| }, | ||
| holder_name: item.router_data.get_optional_billing_full_name(), | ||
| }; |
Contributor
There was a problem hiding this comment.
nit: could be a from implementation
Comment on lines
+592
to
+598
| let device_channel = match platform { | ||
| Some(common_enums::ClientPlatform::Web) | ||
| | Some(common_enums::ClientPlatform::Unknown) | ||
| | None => DeviceChannel::Browser, | ||
| Some(common_enums::ClientPlatform::Ios) | ||
| | Some(common_enums::ClientPlatform::Android) => DeviceChannel::Sdk, | ||
| }; |
Contributor
There was a problem hiding this comment.
nit: could be a from implementation
deepanshu-iiitu
previously approved these changes
Sep 16, 2025
130acde
JeevaRamu0104
previously approved these changes
Sep 17, 2025
13 tasks
Sakilmostak
reviewed
Sep 18, 2025
| pub tenant_id: Option<String>, | ||
| pub platform_url: Option<String>, | ||
| pub account_id: Option<String>, | ||
| pub account_id: Option<serde_json::Value>, |
Contributor
There was a problem hiding this comment.
why this needs to be a serde_json value?
Contributor
Author
There was a problem hiding this comment.
We are using serde_json as account_id is not always a plain text, it has a object
Contributor
There was a problem hiding this comment.
the struct itself need to be completely removed which need to be picked as refactor.
deepanshu-iiitu
requested changes
Sep 18, 2025
crates/hyperswitch_connectors/src/connectors/paysafe/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/paysafe/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/paysafe/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
approved these changes
Sep 18, 2025
JeevaRamu0104
approved these changes
Sep 18, 2025
sai-harsha-vardhan
approved these changes
Sep 18, 2025
Sakilmostak
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
implement Skrill, interac and paysafecard Payment Method
Additional Changes
Motivation and Context
How did you test it?
Response
Complete Payment using redirection
Response
Response
Complete the payment using redirection
We will get
succeededstatusResponse
Complete payment using redirection
Response
Checklist
cargo +nightly fmt --allcargo clippy