feat(connector): [checkout] Add mandate flow#9248
Merged
likhinbopanna merged 9 commits intomainfrom Sep 10, 2025
Merged
Conversation
|
Review changes with Changed Files
|
60561a7 to
e71d951
Compare
deepanshu-iiitu
requested changes
Sep 3, 2025
| }), | ||
| }, | ||
| enums::AuthenticationType::ThreeDs => { | ||
| let challenge_indicator = if item.router_data.request.setup_future_usage |
Contributor
There was a problem hiding this comment.
use is_mandate_payment util here
| metadata, | ||
| }) | ||
|
|
||
| match item.router_data.request.payment_method_data { |
Contributor
There was a problem hiding this comment.
Dont put a second match over payment_method_data
extra fields shoudl be handled in a tuple in the first match over payment_method_data
| }; | ||
|
|
||
| let mandate_reference = | ||
| if item.data.request.setup_future_usage == Some(FutureUsage::OffSession) { |
Contributor
There was a problem hiding this comment.
This check is not needed
Comment on lines
+817
to
+839
| let error_response = if status == AttemptStatus::Failure { | ||
| Some(ErrorResponse { | ||
| status_code: item.http_code, | ||
| code: item | ||
| .response | ||
| .response_code | ||
| .unwrap_or_else(|| consts::NO_ERROR_CODE.to_string()), | ||
| message: item | ||
| .response | ||
| .response_summary | ||
| .clone() | ||
| .unwrap_or_else(|| consts::NO_ERROR_MESSAGE.to_string()), | ||
| reason: item.response.response_summary, | ||
| attempt_status: None, | ||
| connector_transaction_id: Some(item.response.id.clone()), | ||
| network_advice_code: None, | ||
| network_decline_code: None, | ||
| network_error_message: None, | ||
| connector_metadata: None, | ||
| }) | ||
| } else { | ||
| None | ||
| }; |
Contributor
There was a problem hiding this comment.
Directly return ok of error response from here
| }; | ||
|
|
||
| let mandate_reference = | ||
| if item.data.request.setup_future_usage == Some(FutureUsage::OffSession) { |
Contributor
There was a problem hiding this comment.
use is_mandate_payment util
deepanshu-iiitu
previously approved these changes
Sep 3, 2025
deepanshu-iiitu
previously approved these changes
Sep 4, 2025
| [mandates.supported_payment_methods] | ||
| card.credit.connector_list = "stripe,adyen,authorizedotnet,cybersource,datatrans,globalpay,worldpay,multisafepay,nmi,nexinets,noon,bankofamerica,braintree,nuvei,payme,wellsfargo,bamboraapac,elavon,fiuu,nexixpay,novalnet,paybox,paypal,xendit,moneris,archipel,worldpayvantiv" | ||
| card.debit.connector_list = "stripe,adyen,authorizedotnet,cybersource,datatrans,globalpay,worldpay,multisafepay,nmi,nexinets,noon,bankofamerica,braintree,nuvei,payme,wellsfargo,bamboraapac,elavon,fiuu,nexixpay,novalnet,paybox,paypal,xendit,moneris,archipel,worldpayvantiv" | ||
| card.credit.connector_list = "checkout,stripe,adyen,authorizedotnet,cybersource,datatrans,globalpay,worldpay,multisafepay,nmi,nexinets,noon,bankofamerica,braintree,nuvei,payme,wellsfargo,bamboraapac,elavon,fiuu,nexixpay,novalnet,paybox,paypal,xendit,moneris,archipel,worldpayvantiv" |
Contributor
There was a problem hiding this comment.
In the test cases I see that the there are 0 dollar payments.
Then should we add checkout in [zero_mandates.supported_payment_methods] as well ?
Contributor
Author
There was a problem hiding this comment.
missed it, added now.
Contributor
ShankarSinghC
left a comment
There was a problem hiding this comment.
Can you mention why setup_future_usage was added to PaymentsSyncData in the PR description?
ShankarSinghC
approved these changes
Sep 8, 2025
deepanshu-iiitu
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Integrated CIT/MIT and setup mandate flow.
Added
setup_future_usagetoPaymentsSyncDatato support mandate payments.For mandate flows, the source_id (connector mandate ID) must be stored in the MandateReference. To identify whether a payment is mandate-based, we need the setup_future_usage field.
Additional Changes
Motivation and Context
How did you test it?
CIT/MIT:
CIT
RequestResponse
Psync (after comleting redirection)
MIT
RequestResponse
PSync
Setup Mandate flow
CIT
Request
Response
Psync
MIT
Request:
Response:
PSync
Checklist
cargo +nightly fmt --allcargo clippy