feat(revenue_recovery): add support for updating additional card info data from csv to redis by AdityaKumaar21 · Pull Request #9233 · juspay/hyperswitch

AdityaKumaar21 · 2025-09-01T20:39:10Z

Type of Change

Description

The format of csv:-

here CustomerReq_ID is the customer token and Token is the payment token which is used as an identifier in Redis for tokens, ("customer:{}:tokens", customer_id) is used to get token and Token is used to find the field which we need to update.
So, we are parsing the csv and getting the valid records and building a request per record RevenueRecoveryBackfillRequest, from this request we are fetching the data like expiry month, year, card type, card issuer, card network, any of these fields are null, we are updating them from the request.

Complexity:-
for each valid record we are doing two Redis call, one for get and another for set.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

For Revenue recovery service, we are storing data in Redis with format

HGETALL customer:fake_customer123:tokens
1) "fake_token123"
2) "{\"payment_processor_token_details\":{\"payment_processor_token\":\"fake_token123\",\"expiry_month\":\"08\",\"expiry_year\":\"26\",\"card_issuer\":\"Green Dot Bank Dba Bonneville Bank\",\"last_four_digits\":null,\"card_network\":\"Visa\",\"card_type\":\"debit\"},\"inserted_by_attempt_id\":\"12345_att_fake_entry123\",\"error_code\":\"insufficient_funds\",\"daily_retry_history\":{\"2024-05-29\":1},\"scheduled_at\":null}"

in last data migration card_type was populated as null, but for Smart retry logic we need fields like card_type, card_issuer, card_network.
So, inorder to work with Smart retry we need to backfill card_type data from merchant csv.

How did you test it?

cURL:-

curl --location 'http://localhost:8080/recovery/data-backfill' \
--header 'Authorization: api_key =' \
--header 'x-profile-id: pro_PljcGfk8IckJFT1WdFsn' \
--header 'api-key:' \
--form 'file=@"/Users/aditya.c/Downloads/_first_100_rows.csv"'

Router log:-

cURL with query param for updating scheduled at time

curl --location 'http://localhost:8080/v2/recovery/data-backfill?cutoff_time=2025-09-17T10%3A30%3A00' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'x-profile-id: pro_4xOQlxvKwZbLUx8ThJXJ' \
--form 'file=@"/Users/aditya.c/Downloads/sample_merged_data (1).csv"'

Router log:-

Redis-cli log(updating scheduledat to null if cut-off time is greater than scheduled at time):-

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-09-01T20:39:13Z

Review changes with

Changed Files

File	Status
crates/router/src/lib.rs	74% smaller
crates/router/src/core/revenue_recovery/types.rs	53% smaller
crates/router/src/types/storage/revenue_recovery_redis_operation.rs	1% smaller
Cargo.lock	Unsupported file format
crates/api_models/Cargo.toml	Unsupported file format
crates/api_models/src/lib.rs	0% smaller
crates/api_models/src/revenue_recovery_data_backfill.rs	0% smaller
crates/router/src/core.rs	0% smaller
crates/router/src/core/revenue_recovery_data_backfill.rs	0% smaller
crates/router/src/routes.rs	0% smaller
crates/router/src/routes/app.rs	0% smaller
crates/router/src/routes/lock_utils.rs	0% smaller
crates/router/src/routes/revenue_recovery_data_backfill.rs	0% smaller
crates/router_env/src/logger/types.rs	0% smaller

Removed commented-out code for updating Redis token and parsing card data.

Aprabhat19 · 2025-09-10T05:56:45Z

Add support to update all possible values in redis , the ones that we internally compute as well.

Aprabhat19 · 2025-09-10T06:00:56Z

Why are we just updating if the fields are None . Why not update if we know some fields were inserted with wrong information. We should support both data_correction as well as Backfill.