feat(core): [proxy payments] send external vault proxy metadata to UCS#9108
Merged
likhinbopanna merged 2 commits intomainfrom Sep 1, 2025
Merged
feat(core): [proxy payments] send external vault proxy metadata to UCS#9108likhinbopanna merged 2 commits intomainfrom
likhinbopanna merged 2 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
2 tasks
prasunna09
reviewed
Sep 1, 2025
Comment on lines
+537
to
+543
| let unified_service_vault_metdata = match external_vault_connector { | ||
| api_enums::VaultConnectors::Vgs => { | ||
| let vgs_metadata: ExternalVaultConnectorMetadata = external_vault_metadata | ||
| .expose() | ||
| .parse_value("ExternalVaultConnectorMetadata") | ||
| .change_context(UnifiedConnectorServiceError::ParsingFailed) | ||
| .attach_printable("Failed to parse Vgs connector metadata")?; |
Contributor
There was a problem hiding this comment.
nit: this can be a try_from
prasunna09
approved these changes
Sep 1, 2025
| &self, | ||
| payment_authorize_request: payments_grpc::PaymentServiceAuthorizeRequest, | ||
| connector_auth_metadata: ConnectorAuthMetadata, | ||
| external_vault_proxy_metadata: Option<String>, |
Contributor
There was a problem hiding this comment.
nit: please add a comment that this will be a base 64 encode value
su-shivanshmathur
approved these changes
Sep 1, 2025
jarnura
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Not tested, need proxy module completely for testing
Checklist
cargo +nightly fmt --allcargo clippy