feat(router): Add v2 payment cancellation flow by ayush22667 · Pull Request #9083 · juspay/hyperswitch

ayush22667 · 2025-08-29T06:04:40Z

Type of Change

Description

Add V2 payments_cancel flow by endpoint {{baseUrl}}/v2/payments/:payment_id/cancel.A payment can be cancelled when the status is RequiresCapture, PartiallyAuthorizedAndRequiresCapture, or PartiallyCapturedAndCapturable.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Request:

curl --location 'http://localhost:8080/v2/payments/12345_pay_0199568c7d307cb093a2f9d517fec5cc/cancel' \
--header 'X-Profile-Id: pro_ICrZFKL8QL6GlxNOuGiT' \
--header 'Authorization: api-key=dev_lLeDL7DZk8Vf8vF7PTd53ces09iGYEerHYDBQzle5s1N1QPpzj3pKViOnv7VsQd5' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_lLeDL7DZk8Vf8vF7PTd53ces09iGYEerHYDBQzle5s1N1QPpzj3pKViOnv7VsQd5' \
--data '{
    "cancellation_reason": "Requested by Merchant"
}'

Response:

{
    "id": "12345_pay_019956bfbb0472f28d713b8190b897b7",
    "status": "cancelled",
    "cancellation_reason": "Requested by Merchant",
    "amount": {
        "order_amount": 100,
        "currency": "USD",
        "shipping_cost": null,
        "order_tax_amount": null,
        "external_tax_calculation": "skip",
        "surcharge_calculation": "skip",
        "surcharge_amount": null,
        "tax_on_surcharge": null,
        "net_amount": 100,
        "amount_to_capture": null,
        "amount_capturable": 100,
        "amount_captured": 0
    },
    "customer_id": "12345_cus_0199568c731e77d2960fde597ad801ac",
    "connector": "authorizedotnet",
    "created": "2025-09-17T08:17:09.937Z",
    "payment_method_type": "card",
    "payment_method_subtype": "credit",
    "attempts": null,
    "return_url": null
}

closes #9082

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-08-29T06:04:42Z

Review changes with

Changed Files

File	Status
crates/router/src/routes/app.rs	73% smaller
crates/router/src/core/payments/flows/cancel_flow.rs	37% smaller
crates/router/src/core/payments/transformers.rs	6% smaller
crates/router/src/core/payments.rs	1% smaller
api-reference/v2/openapi_spec_v2.json	0% smaller
crates/api_models/src/events/payment.rs	0% smaller
crates/api_models/src/payments.rs	0% smaller
crates/diesel_models/src/payment_attempt.rs	0% smaller
crates/hyperswitch_domain_models/src/payments.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_intent.rs	0% smaller
crates/hyperswitch_domain_models/src/router_data.rs	0% smaller
crates/hyperswitch_interfaces/src/conversion_impls.rs	0% smaller
crates/router/src/core/payments/operations.rs	0% smaller
crates/router/src/core/payments/operations/payment_cancel_v2.rs	0% smaller
crates/router/src/core/payments/operations/payment_response.rs	0% smaller
crates/router/src/routes/payments.rs	0% smaller

crates/router/src/core/payments/operations/payment_cancel_v2.rs

crates/router/src/core/payments/flows/cancel_flow.rs

crates/router/src/core/payments/transformers.rs

prasunna09 · 2025-09-04T07:17:17Z

Also can we add a screenshot of connector cancel request and response in the test cases

crates/router/src/core/payments/operations/payment_cancel_v2.rs

crates/router/src/core/payments/operations/payment_response.rs

crates/router/src/core/payments/operations/payment_cancel_v2.rs

prasunna09

no request response types are introduced in pr.
Are reusing the v1 structs?
then that is wrong, we need to add new structs for v2 since v1 has different type for payment id compared to v2

…t/paymentcancel_v2

…erswitch into feat/paymentcancel_v2

crates/api_models/src/payments.rs

crates/router/src/core/payments.rs

crates/router/src/core/payments/operations/payment_cancel_v2.rs

crates/router/src/core/payments/transformers.rs

crates/router/src/core/payments/operations/payment_response.rs

ayush22667 requested review from a team as code owners August 29, 2025 06:04

ayush22667 self-assigned this Aug 29, 2025

ayush22667 added api-v2 C-feature Category: Feature request or enhancement labels Aug 29, 2025

ayush22667 changed the title ~~fea(router)t: Add v2 payment cancellation flow~~ fea(router): Add v2 payment cancellation flow Aug 29, 2025

ayush22667 changed the title ~~fea(router): Add v2 payment cancellation flow~~ feat(router): Add v2 payment cancellation flow Aug 31, 2025

prasunna09 requested changes Sep 4, 2025

View reviewed changes

ayush22667 requested a review from prasunna09 September 4, 2025 09:23

ayush22667 force-pushed the feat/paymentcancel_v2 branch 3 times, most recently from 88f81b4 to f2f7577 Compare September 4, 2025 11:10

su-shivanshmathur previously approved these changes Sep 4, 2025

View reviewed changes

ayush22667 added 3 commits September 7, 2025 14:47

feat(router): Add v2 payment cancellation flow

9bef151

feat(router): handle cancellation reason in payment attempt updates

7029c85

refactor(router): Generalize payment cancel flow and encapsulate data

19a617f

ayush22667 dismissed su-shivanshmathur’s stale review via 19a617f September 7, 2025 09:23

ayush22667 force-pushed the feat/paymentcancel_v2 branch from f2f7577 to 19a617f Compare September 7, 2025 09:23

Merge branch 'main' into feat/paymentcancel_v2

0aa1bee

su-shivanshmathur previously approved these changes Sep 8, 2025

View reviewed changes

ayush22667 requested review from prasunna09 and removed request for prasunna09 September 8, 2025 05:48

prasunna09 requested changes Sep 8, 2025

View reviewed changes

feat(payments): Address pr comments

d289994

ayush22667 dismissed su-shivanshmathur’s stale review via d289994 September 10, 2025 07:05

ayush22667 requested review from prasunna09 and su-shivanshmathur and removed request for prasunna09 September 10, 2025 13:41

ayush22667 removed the request for review from su-shivanshmathur September 11, 2025 05:51

Merge branch 'main' into feat/paymentcancel_v2

5946dce

ayush22667 requested review from prasunna09 and su-shivanshmathur and removed request for prasunna09 and su-shivanshmathur September 11, 2025 05:52

prasunna09 reviewed Sep 11, 2025

View reviewed changes

crates/router/src/core/payments/operations/payment_cancel_v2.rs Show resolved Hide resolved

prasunna09 requested changes Sep 16, 2025

View reviewed changes

feat(payments): add payment cancel request and response for v2

632b40e

ayush22667 requested a review from a team as a code owner September 17, 2025 07:44

hyperswitch-bot bot and others added 2 commits September 17, 2025 07:51

docs(openapi): re-generate OpenAPI specification

2f09912

Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…

979489f

…t/paymentcancel_v2

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 17, 2025

ayush22667 added 2 commits September 17, 2025 13:48

Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…

d43fbe6

…t/paymentcancel_v2

Merge branch 'feat/paymentcancel_v2' of https://github.com/juspay/hyp…

5364182

…erswitch into feat/paymentcancel_v2

prasunna09 requested changes Sep 17, 2025

View reviewed changes

ayush22667 and others added 2 commits September 18, 2025 11:31

feat(payments): refactor connector field type

cfdd61d

chore: run formatter

f3fce0b

prasunna09 requested changes Sep 18, 2025

View reviewed changes

crates/router/src/core/payments/operations/payment_response.rs Outdated Show resolved Hide resolved

crates/router/src/core/payments/operations/payment_response.rs Outdated Show resolved Hide resolved

fix(payments): enhance error handling for payment updates

627856f

prasunna09 approved these changes Sep 18, 2025

View reviewed changes

su-shivanshmathur approved these changes Sep 22, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Sep 22, 2025

Merged via the queue into main with commit 617b3fa Sep 22, 2025
21 of 25 checks passed

likhinbopanna deleted the feat/paymentcancel_v2 branch September 22, 2025 18:39

AnuthaDev mentioned this pull request Oct 21, 2025

feat(router): Implement Payments Void endpoint for v2 #7077

Closed

14 tasks

Conversation

ayush22667 commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prasunna09 commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prasunna09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ayush22667 commented Aug 29, 2025 •

edited

Loading

semanticdiff-com bot commented Aug 29, 2025 •

edited

Loading

prasunna09 commented Sep 4, 2025 •

edited

Loading